You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/22 19:29:49 UTC
[GitHub] [nifi] nagasivanath opened a new pull request #4009: NIFI-6968
Create Connection Model Allows Multiple Adds
nagasivanath opened a new pull request #4009: NIFI-6968 Create Connection Model Allows Multiple Adds
URL: https://github.com/apache/nifi/pull/4009
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
fixes bug NIFI-6968 Create Connection Model Allows Multiple Adds
**Root Cause:** In the process of creation of connection, the add / apply button is not disabled , due to which, when the network is slow & when the button is clicked twice unknowingly, the requests are sent multiple times , so multiple connections are created.
**Fix:** Disable the buttons when the add/update connection is in progress, enable them back after the action.
**Impacted Areas:** the same issue in case of configuring connections & clicking on Update, also the cancel button should also be disabled when the creation or modification is in process
**Tested in :** Add Connection, Update connection scenarios using the chrome's network throttling feature making the network very slow
**After Fix:** the screenshots are taken during the progress, so they are disabled
Update Connection -
<img width="1439" alt="update connection after fix" src="https://user-images.githubusercontent.com/16460179/72926948-4bc9a780-3d7b-11ea-8df7-89f7ba93b0ba.png">
Add Connection -
<img width="1440" alt="add connection after fix" src="https://user-images.githubusercontent.com/16460179/72926864-2b015200-3d7b-11ea-9032-9159df5e7588.png">
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] nagasivanath closed pull request #4009: NIFI-6968 Create
Connection Model Allows Multiple Adds
Posted by GitBox <gi...@apache.org>.
nagasivanath closed pull request #4009: NIFI-6968 Create Connection Model Allows Multiple Adds
URL: https://github.com/apache/nifi/pull/4009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services