You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2014/06/23 20:50:38 UTC
[5/6] android commit: Delete explicit activity.finish() in back
button handling. No change in behaviour.
Delete explicit activity.finish() in back button handling. No change in behaviour.
The default handling calls through to Activity.onBackPressed(), which
by default results in activity.finish(), but can be customized by the
app.
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/297f862c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/297f862c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/297f862c
Branch: refs/heads/master
Commit: 297f862ccc20de9506a5d5296f98ce5724dc43c0
Parents: 141bbfb
Author: Andrew Grieve <ag...@chromium.org>
Authored: Mon Jun 23 14:18:54 2014 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Jun 23 14:18:54 2014 -0400
----------------------------------------------------------------------
framework/src/org/apache/cordova/CordovaWebView.java | 6 ------
1 file changed, 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/297f862c/framework/src/org/apache/cordova/CordovaWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaWebView.java b/framework/src/org/apache/cordova/CordovaWebView.java
index bb51a7a..3b3f80d 100755
--- a/framework/src/org/apache/cordova/CordovaWebView.java
+++ b/framework/src/org/apache/cordova/CordovaWebView.java
@@ -775,12 +775,6 @@ public class CordovaWebView extends WebView {
return true;
}
// If not, then invoke default behavior
- else {
- //this.activityState = ACTIVITY_EXITING;
- //return false;
- // If they hit back button when app is initializing, app should exit instead of hang until initialization (CB2-458)
- this.cordova.getActivity().finish();
- }
}
}
}