You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/08 13:02:34 UTC

[GitHub] eolivelli commented on a change in pull request #925: Issue611: restrict max ensemble change numbers

eolivelli commented on a change in pull request #925: Issue611: restrict max ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r160080955
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
 ##########
 @@ -424,11 +498,20 @@ protected void setupBookieClientAddEntry() {
                         ledgerId, entryId, bookieSocketAddress, ctx);
                 } else {
                     if (getMockLedgerContentsInBookie(ledgerId, bookieSocketAddress).isEmpty()) {
-                        registerMockEntryForRead(ledgerId, BookieProtocol.LAST_ADD_CONFIRMED, bookieSocketAddress,
-                            new byte[0], BookieProtocol.INVALID_ENTRY_ID);
+                        try {
+                            registerMockEntryForRead(ledgerId, BookieProtocol.LAST_ADD_CONFIRMED, bookieSocketAddress,
+                                    new byte[0], BookieProtocol.INVALID_ENTRY_ID);
+                        } catch (BKException bke) {
+
+                        }
 
 Review comment:
   Fail the test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services