[jira] [Resolved] (GROOVY-4816) Visiting Empty expressions

["Eric Milles (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GROOVY-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Milles resolved GROOVY-4816.
---------------------------------
    Fix Version/s: 3.0.0-rc-1
       Resolution: Fixed

https://github.com/apache/groovy/commit/cba00841e1f5f36acc056816abbbd17e6352e9e2#diff-7efced40b275f1e9219b2e318c86b7f6

> Visiting Empty expressions
> --------------------------
>
>                 Key: GROOVY-4816
>                 URL: https://issues.apache.org/jira/browse/GROOVY-4816
>             Project: Groovy
>          Issue Type: Improvement
>          Components: Compiler
>    Affects Versions: 1.8.0
>            Reporter: Andrew Eisenberg
>            Priority: Major
>             Fix For: 3.0.0-rc-1
>
>
> We are trying to integrate some parts of the Groovy-Eclipse patch on the Groovy compiler back into the compiler itself.  One such change is this.
> In GroovyCodeVisitor, there is no method to visit empty expressions.  For consistency, we should be visiting every kind of expression.
> Please add this to GroovyCodeVisitor:
> {code}
> void visitEmptyExpression(EmptyExpression expression); 
> {code}
> and this to {{EmptyExpression}} inside of the otherwise empty {{visit}} method:
> {code}
> visitor.visitEmptyExpression(this);
> {code}
> I realize that this would break classes that currently implement GroovyCodeVisitor, but this is an inconsistency in your AST visitor pattern.  So I am not sure of the best way to proceed.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)