You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/03/07 18:24:00 UTC
[GitHub] [arrow] assignUser commented on a diff in pull request #34488: MINOR: [Go][CI] Add openssl to macos CGO runs
assignUser commented on code in PR #34488:
URL: https://github.com/apache/arrow/pull/34488#discussion_r1128352620
##########
.github/workflows/go.yml:
##########
@@ -300,18 +300,22 @@ jobs:
with:
go-version: ${{ matrix.go }}
cache: true
- cache-dependency-path: go/go.sum
+ cache-dependency-path: go/go.sum
- name: Brew Install Arrow and pkg-config
shell: bash
run: brew install apache-arrow pkg-config
- name: Install staticcheck
run: go install honnef.co/go/tools/cmd/staticcheck@${{ matrix.staticcheck }}
- name: Build
shell: bash
- run: ci/scripts/go_build.sh $(pwd)
+ run: |
+ export PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH
+ ci/scripts/go_build.sh $(pwd)
- name: Test
shell: bash
- run: ci/scripts/go_test.sh $(pwd)
+ run: |
+ export PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH
+ ci/scripts/go_test.sh $(pwd)
Review Comment:
```suggestion
run: ci/scripts/go_test.sh $(pwd)
```
##########
.github/workflows/go.yml:
##########
@@ -300,18 +300,22 @@ jobs:
with:
go-version: ${{ matrix.go }}
cache: true
- cache-dependency-path: go/go.sum
+ cache-dependency-path: go/go.sum
Review Comment:
nit:
```suggestion
cache-dependency-path: go/go.sum
```
##########
.github/workflows/go.yml:
##########
@@ -300,18 +300,22 @@ jobs:
with:
go-version: ${{ matrix.go }}
cache: true
- cache-dependency-path: go/go.sum
+ cache-dependency-path: go/go.sum
- name: Brew Install Arrow and pkg-config
shell: bash
run: brew install apache-arrow pkg-config
- name: Install staticcheck
run: go install honnef.co/go/tools/cmd/staticcheck@${{ matrix.staticcheck }}
- name: Build
shell: bash
- run: ci/scripts/go_build.sh $(pwd)
+ run: |
+ export PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH
Review Comment:
This should update it for all following steps by setting it once :)
```suggestion
echo "PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org