You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 18:13:06 UTC

[GitHub] [airflow] potiuk opened a new pull request #21022: Fixed tests failing on unittest.skipIf

potiuk opened a new pull request #21022:
URL: https://github.com/apache/airflow/pull/21022


   The change #21003 broke TestDeprecation class tests by removing
   TestCase and leaving self.skipTest.
   
   This change replaces self.skipTest with pytest.skipTest everywhere.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#discussion_r789913899



##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -29,9 +31,7 @@
     snakebite_loaded = True
 except ImportError:
     snakebite_loaded = False
-
-if not snakebite_loaded:
-    raise unittest.SkipTest("Skipping test because HDFSHook is not installed")
+    pytestmark = pytest.mark.skip("Skipping test because HDFSHook is not installed")

Review comment:
       Hmm, why are you defining `pytestmark`? It's not being used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21022:
URL: https://github.com/apache/airflow/pull/21022


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#discussion_r789916277



##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -82,6 +82,8 @@ def test_get_autoconfig_client_no_conn(self, mock_client):
 
     @mock.patch('airflow.providers.apache.hdfs.hooks.hdfs.HDFSHook.get_connections')
     def test_get_ha_client(self, mock_get_connections):
+        if not snakebite_loaded:
+            raise pytest.skip("Skipping test because HDFSHook is not installed")

Review comment:
       We don't need this, or `snakebite_loaded` any longer, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#discussion_r789914655



##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -29,9 +31,7 @@
     snakebite_loaded = True
 except ImportError:
     snakebite_loaded = False
-
-if not snakebite_loaded:
-    raise unittest.SkipTest("Skipping test because HDFSHook is not installed")
+    pytestmark = pytest.mark.skip("Skipping test because HDFSHook is not installed")

Review comment:
       Ah TIL, it's a global var, didn't know that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#issuecomment-1018723504


   @jedcunningham  - you might want to re-take a look. I also had to fix test_hdfs "module" skip (which pytest.skipIf did not handle nicely).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#discussion_r789942916



##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -82,6 +82,8 @@ def test_get_autoconfig_client_no_conn(self, mock_client):
 
     @mock.patch('airflow.providers.apache.hdfs.hooks.hdfs.HDFSHook.get_connections')
     def test_get_ha_client(self, mock_get_connections):
+        if not snakebite_loaded:
+            raise pytest.skip("Skipping test because HDFSHook is not installed")

Review comment:
       We don't. But I noticed it too late :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#discussion_r789944562



##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -82,6 +82,8 @@ def test_get_autoconfig_client_no_conn(self, mock_client):
 
     @mock.patch('airflow.providers.apache.hdfs.hooks.hdfs.HDFSHook.get_connections')
     def test_get_ha_client(self, mock_get_connections):
+        if not snakebite_loaded:
+            raise pytest.skip("Skipping test because HDFSHook is not installed")

Review comment:
       Here you are https://github.com/apache/airflow/pull/21025




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#issuecomment-1018759706


   Right - I think I finally got it right with pytestmark


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #21022: Fixed tests failing on Python 3.8

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#issuecomment-1018687313


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21022:
URL: https://github.com/apache/airflow/pull/21022#discussion_r789924610



##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -29,9 +31,7 @@
     snakebite_loaded = True
 except ImportError:
     snakebite_loaded = False
-
-if not snakebite_loaded:
-    raise unittest.SkipTest("Skipping test because HDFSHook is not installed")
+    pytestmark = pytest.mark.skip("Skipping test because HDFSHook is not installed")

Review comment:
       Yeah. learn about it today too :)

##########
File path: tests/providers/apache/hdfs/hooks/test_hdfs.py
##########
@@ -29,9 +31,7 @@
     snakebite_loaded = True
 except ImportError:
     snakebite_loaded = False
-
-if not snakebite_loaded:
-    raise unittest.SkipTest("Skipping test because HDFSHook is not installed")
+    pytestmark = pytest.mark.skip("Skipping test because HDFSHook is not installed")

Review comment:
       Yeah. learned about it today too :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #21022: Fixed tests failing on unittest.skipIf

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21022:
URL: https://github.com/apache/airflow/pull/21022


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org