[jira] [Created] (IMPALA-12595) Allow automatic removal of old logs from previous PID

["Riza Suminto (Jira)" <ji...@apache.org>]

Riza Suminto created IMPALA-12595:
-------------------------------------

             Summary: Allow automatic removal of old logs from previous PID
                 Key: IMPALA-12595
                 URL: https://issues.apache.org/jira/browse/IMPALA-12595
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
    Affects Versions: Impala 4.3.0
            Reporter: Riza Suminto


IMPALA-11184 add code to target specific file name pattern for log rotation
{code:java}
// We specifically target the base file name created by glog.
// Glog's default base file name follow this pattern:
// "<program name>.<hostname>.<user name>.log.<severity level>.<date>-<time>.<pid>"
inline string GlobPatternForLog(google::LogSeverity severity) {
  return strings::Substitute("$0/$1*.log.$2.*.$3", FLAGS_log_dir,
      google::ProgramInvocationShortName(), google::GetLogSeverityName(severity),
      getpid());
}{code}
The <pid> component in the pattern grant safety. That is, it is strictly limit log rotation to only consider log files made by the currently running Impalad and exclude logs made by previous PID or other living-colocated Impalads.

The downside of this limit is that logs can start accumulate in a node when impalad is frequently restarted and is only resolvable by admin doing manual log removal. To help avoid this manual removal, Impala should consider relaxing the limit a bit by dropping the <pid> pattern, at least once on Impalad startup or at very first log rotation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org