You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/29 04:20:24 UTC
[GitHub] [trafficserver] masaori335 opened a new pull request #7225: Increment ssl_error_syscall only if not EOF
masaori335 opened a new pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225
Similar to #5389, below 2 SSL metrics are confusing / misleading.
1. `proxy.process.ssl.ssl_error_syscall`
I observed this counter is incremented, but almost all cases are EOF. It'd be useful that this is incremented only if it's not EOF.
2. `proxy.process.ssl.ssl_error_read_eos`
This is not incremented anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #7225: Increment ssl_error_syscall only if not EOF
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225#discussion_r497156908
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -306,15 +306,14 @@ ssl_read_from_net(SSLNetVConnection *sslvc, EThread *lthread, int64_t &ret)
Debug("ssl.error", "SSL_ERROR_WOULD_BLOCK(read/x509 lookup)");
break;
case SSL_ERROR_SYSCALL:
- SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
if (nread != 0) {
// not EOF
+ SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
event = SSL_READ_ERROR;
ret = errno;
Debug("ssl.error", "SSL_ERROR_SYSCALL, underlying IO error: %s", strerror(errno));
} else {
// then EOF observed, treat it as EOS
Review comment:
Actually, it's my first idea. But I decided to do nothing to follow what we did for `SSL_ERROR_WANT_WRITE`, `SSL_ERROR_WANT_READ`, and `SSL_ERROR_ZERO_RETURN` at #5389.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #7225: Increment ssl_error_syscall only if not EOF
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225#discussion_r497156908
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -306,15 +306,14 @@ ssl_read_from_net(SSLNetVConnection *sslvc, EThread *lthread, int64_t &ret)
Debug("ssl.error", "SSL_ERROR_WOULD_BLOCK(read/x509 lookup)");
break;
case SSL_ERROR_SYSCALL:
- SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
if (nread != 0) {
// not EOF
+ SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
event = SSL_READ_ERROR;
ret = errno;
Debug("ssl.error", "SSL_ERROR_SYSCALL, underlying IO error: %s", strerror(errno));
} else {
// then EOF observed, treat it as EOS
Review comment:
Actually, it's my first idea. But I decided to do nothing to follow what we did for `SSL_ERROR_WANT_WRITE`, `SSL_ERROR_WANT_READ`, and `SSL_ERROR_ZERO_RETURN` with #5389.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7225: Increment ssl_error_syscall only if not EOF
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225#discussion_r496915838
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -306,15 +306,14 @@ ssl_read_from_net(SSLNetVConnection *sslvc, EThread *lthread, int64_t &ret)
Debug("ssl.error", "SSL_ERROR_WOULD_BLOCK(read/x509 lookup)");
break;
case SSL_ERROR_SYSCALL:
- SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
if (nread != 0) {
// not EOF
+ SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
event = SSL_READ_ERROR;
ret = errno;
Debug("ssl.error", "SSL_ERROR_SYSCALL, underlying IO error: %s", strerror(errno));
} else {
// then EOF observed, treat it as EOS
Review comment:
Do we want to track EOS here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 merged pull request #7225: Increment ssl_error_syscall only if not EOF
Posted by GitBox <gi...@apache.org>.
masaori335 merged pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #7225: Increment ssl_error_syscall only if not EOF
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225#discussion_r497158109
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -306,15 +306,14 @@ ssl_read_from_net(SSLNetVConnection *sslvc, EThread *lthread, int64_t &ret)
Debug("ssl.error", "SSL_ERROR_WOULD_BLOCK(read/x509 lookup)");
break;
case SSL_ERROR_SYSCALL:
- SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
if (nread != 0) {
// not EOF
+ SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
event = SSL_READ_ERROR;
ret = errno;
Debug("ssl.error", "SSL_ERROR_SYSCALL, underlying IO error: %s", strerror(errno));
} else {
// then EOF observed, treat it as EOS
Review comment:
If we really need these stats, let's restore all of them with renaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7225: Increment ssl_error_syscall only if not EOF
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225#issuecomment-702415388
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org