You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/12/08 20:53:59 UTC
Review Request 28806: More logging in MaintenanceController.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28806/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-935
https://issues.apache.org/jira/browse/AURORA-935
Repository: aurora
Description
-------
More logging in MaintenanceController.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 8e6f4e7c18df4bac4dab747f05803e8e25b43cda
Diff: https://reviews.apache.org/r/28806/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 28806: More logging in MaintenanceController.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28806/#review64269
-----------------------------------------------------------
Master (a9e1217) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 8, 2014, 7:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28806/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 7:53 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-935
> https://issues.apache.org/jira/browse/AURORA-935
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More logging in MaintenanceController.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 8e6f4e7c18df4bac4dab747f05803e8e25b43cda
>
> Diff: https://reviews.apache.org/r/28806/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28806: More logging in MaintenanceController.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28806/#review64267
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java
<https://reviews.apache.org/r/28806/#comment106903>
How about `"Host %s still DRAINING tasks: %s"`
- Bill Farner
On Dec. 8, 2014, 7:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28806/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 7:53 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-935
> https://issues.apache.org/jira/browse/AURORA-935
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More logging in MaintenanceController.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 8e6f4e7c18df4bac4dab747f05803e8e25b43cda
>
> Diff: https://reviews.apache.org/r/28806/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>