You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2025/03/23 04:18:56 UTC
(shardingsphere) branch master updated: Refactor GlobalLockPersistService (#35061)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 0b85117ae23 Refactor GlobalLockPersistService (#35061)
0b85117ae23 is described below
commit 0b85117ae236da2ff2c061ab1da15427746e2fda
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Mar 23 12:18:49 2025 +0800
Refactor GlobalLockPersistService (#35061)
---
.../cluster/lock/global/GlobalLockPersistService.java | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/lock/global/GlobalLockPersistService.java b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/lock/global/GlobalLockPersistService.java
index 586a408a591..8e1146f9bc3 100644
--- a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/lock/global/GlobalLockPersistService.java
+++ b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/lock/global/GlobalLockPersistService.java
@@ -17,16 +17,19 @@
package org.apache.shardingsphere.mode.manager.cluster.lock.global;
-import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.mode.repository.cluster.ClusterPersistRepository;
+import org.apache.shardingsphere.mode.repository.cluster.lock.holder.DistributedLockHolder;
/**
* Global lock persist service.
*/
-@RequiredArgsConstructor
public final class GlobalLockPersistService {
- private final ClusterPersistRepository repository;
+ private final DistributedLockHolder lockHolder;
+
+ public GlobalLockPersistService(final ClusterPersistRepository repository) {
+ lockHolder = repository.getDistributedLockHolder();
+ }
/**
* Try lock.
@@ -36,7 +39,7 @@ public final class GlobalLockPersistService {
* @return is locked or not
*/
public boolean tryLock(final GlobalLockDefinition lockDefinition, final long timeoutMillis) {
- return repository.getDistributedLockHolder().getDistributedLock(lockDefinition.getLockKey()).tryLock(timeoutMillis);
+ return lockHolder.getDistributedLock(lockDefinition.getLockKey()).tryLock(timeoutMillis);
}
/**
@@ -45,6 +48,6 @@ public final class GlobalLockPersistService {
* @param lockDefinition lock definition
*/
public void unlock(final GlobalLockDefinition lockDefinition) {
- repository.getDistributedLockHolder().getDistributedLock(lockDefinition.getLockKey()).unlock();
+ lockHolder.getDistributedLock(lockDefinition.getLockKey()).unlock();
}
}