You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/28 15:24:18 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2532: Move ZooKeeperTestingServer
milleruntime opened a new pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532
* ZooKeeperTestingServer is only used by the tests in fate.zookeeper pkg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed pull request #2532: Move ZooKeeperTestingServer
Posted by GitBox <gi...@apache.org>.
milleruntime closed pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2532: Move ZooKeeperTestingServer
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532#issuecomment-1054413907
OK no problem. This can definitely wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2532: Move ZooKeeperTestingServer
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532#issuecomment-1054604778
OK. I just thought it wasn't worth having a package just for this one class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2532: Move ZooKeeperTestingServer
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532#issuecomment-1054408791
I use it elsewhere - and it has utility outside of just fate testing if other wise to use it in improving testing beyond just using mocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2532: Move ZooKeeperTestingServer
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532#issuecomment-1054606079
> OK. I just thought it wasn't worth having a package just for this one class.
I think there's a strong possibility that we could put more tests in this package later, for non-FaTE related ZK things. Packages are free, though, so I don't think it's a big deal. We can use as many as we want. (One class per package!!!! haha, just kidding).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2532: Move ZooKeeperTestingServer
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2532:
URL: https://github.com/apache/accumulo/pull/2532#issuecomment-1054415668
> I use it elsewhere - and it has utility outside of just fate testing if other wise to use it in improving testing beyond just using mocks.
I agree. This can definitely wait until after merging your ZK changes. If you have tests that use it, then it would make sense to keep it or move it up a package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org