You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/23 09:46:25 UTC
[GitHub] [skywalking] furaul opened a new issue #6064: Exception with thrift plugin
furaul opened a new issue #6064:
URL: https://github.com/apache/skywalking/issues/6064
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [X] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
Is thrift plugin compatiable with thrift 0.9.3 & 0.13.0？
___
### Bug
- Which version of SkyWalking, OS, and JRE?
- skywalking 8.2.0 thrift 0.9.3 , 0.13.0
- Which company or project?
- didi
- What happened?
We are spreading skywalking in our company.
Yesterday, we encountered a problem when we use thrift & thrift plugin in our project.
The error message is
`
ERROR 2020-12-22 22:44:34:330 MessageProcess-4 ClientOutProtocolWrapper : Failed to propagating CarrierItems.
java.lang.IllegalStateException: Exit span doesn't include meaningful ThreadPoolExecutor information.
at org.apache.skywalking.apm.agent.core.context.TracingContext.inject(TracingContext.java:160)
at org.apache.skywalking.apm.agent.core.context.TracingContext.inject(TracingContext.java:140)
at org.apache.skywalking.apm.agent.core.context.ContextManager.inject(ContextManager.java:123)
at org.apache.skywalking.apm.plugin.thrift.wrapper.ClientOutProtocolWrapper.writeFieldStop(ClientOutProtocolWrapper.java:59)
at at com.xiaojukeji.code............
at org.apache.thrift.TServiceClient.sendBase$original$7XkPFApx(TServiceClient.java:71)
at org.apache.thrift.TServiceClient.sendBase$original$7XkPFApx$accessor$soztpFzs(TServiceClient.java)
at org.apache.thrift.TServiceClient$auxiliary$AHznHXHP.call(Unknown Source)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:86)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at com.xiaojukeji.code.............
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
`
We know the exception is that peer is null.
We try to debug this problem, and find that in org.apache.skywalking.apm.plugin.thrift.client.TServiceClientInterceptor
`
public void onConstruct(EnhancedInstance objInst, Object[] allArguments) throws NoSuchFieldException, IllegalAccessException {
if (!(allArguments[1] instanceof ClientOutProtocolWrapper)) {
TProtocol protocol = (TProtocol)allArguments[1];
ReflectionUtils.setValue(TServiceClient.class, objInst, "oprot_", new ClientOutProtocolWrapper(protocol));
Object dynamicField = ((EnhancedInstance)protocol.getTransport()).getSkyWalkingDynamicField();// throws Exception
objInst.setSkyWalkingDynamicField(Objects.isNull(dynamicField) ? "UNKNOWN" : dynamicField);
}
}
`
Exceptions come out from the code above.
The exception message is
`
java.lang.ClassCastException: org.apache.thrift.transport.TFramedTransport cannot be cast to org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
`
It is easy to reproduce this problem.
___
### Requirement or improvement
- Please check & fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] 1ang1ang commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
1ang1ang commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-1000795836
still have Exception use java agent:8.8.0,thrift 0.11.0, not fix this problem yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] qiyue0421 commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
qiyue0421 commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-1017281049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ZhangShangyu commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
ZhangShangyu commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-809258884
Hi, was this problem fixed?
I use SkyWalking 8.4.0
thrift 0.11.0 in my target application
throw exception and msg is:
cannot be cast to org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
at org.apache.skywalking.apm.plugin.thrift.client.TServiceClientInterceptor.onConstruct(TServiceClientInterceptor.java:59)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] qiyue0421 removed a comment on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
qiyue0421 removed a comment on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-1017281155
You are right, the developer feedback used jaeger sdk, maybe the previous technician testing jaeger (haha, I'm not too sure), currently using skywalking is better, sincerely thank you for your reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-751135560
No update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ZhangShangyu removed a comment on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
ZhangShangyu removed a comment on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-809258884
Hi, was this problem fixed?
I use SkyWalking 8.4.0
thrift 0.11.0 in my target application
throw exception and msg is:
cannot be cast to org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
at org.apache.skywalking.apm.plugin.thrift.client.TServiceClientInterceptor.onConstruct(TServiceClientInterceptor.java:59)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-1017254682
@qiyue0421 You are different. From the log stack, it is clear you are using Jeager SDK, which we never tested.
And why do you run 2 tracing cores at the same time? It could be a very complex scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-750049840
Could you try the master branch? We recently merged a fix(#5989).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] qiyue0421 commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
qiyue0421 commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-1017252869
`ERROR 2022-01-20 16:55:37:747 jaeger.RemoteReporter-QueueProcessor ClientOutProtocolWrapper : Failed to propagating CarrierItems.
java.lang.IllegalStateException: Exit span doesn't include meaningful peer information.
at org.apache.skywalking.apm.agent.core.context.TracingContext.inject(TracingContext.java:168)
at org.apache.skywalking.apm.agent.core.context.TracingContext.inject(TracingContext.java:148)
at org.apache.skywalking.apm.agent.core.context.ContextManager.inject(ContextManager.java:137)
at org.apache.skywalking.apm.plugin.thrift.wrapper.ClientOutProtocolWrapper.writeFieldStop(ClientOutProtocolWrapper.java:59)
at io.jaegertracing.thriftjava.Tag$TagStandardScheme.write(Tag.java:931)
at io.jaegertracing.thriftjava.Tag$TagStandardScheme.write(Tag.java:809)
at io.jaegertracing.thriftjava.Tag.write(Tag.java:709)
at io.jaegertracing.thriftjava.Process$ProcessStandardScheme.write(Process.java:468)
at io.jaegertracing.thriftjava.Process$ProcessStandardScheme.write(Process.java:402)
at io.jaegertracing.thriftjava.Process.write(Process.java:343)
at io.jaegertracing.thriftjava.Batch$BatchStandardScheme.write(Batch.java:464)
at io.jaegertracing.thriftjava.Batch$BatchStandardScheme.write(Batch.java:407)
at io.jaegertracing.thriftjava.Batch.write(Batch.java:344)
at io.jaegertracing.agent.thrift.Agent$emitBatch_args$emitBatch_argsStandardScheme.write(Agent.java:1056)
at io.jaegertracing.agent.thrift.Agent$emitBatch_args$emitBatch_argsStandardScheme.write(Agent.java:1018)
at io.jaegertracing.agent.thrift.Agent$emitBatch_args.write(Agent.java:969)
at org.apache.thrift.TServiceClient.sendBase$original$yadqJ0t1(TServiceClient.java:71)
at org.apache.thrift.TServiceClient.sendBase$original$yadqJ0t1$accessor$q8TELQr2(TServiceClient.java)
at org.apache.thrift.TServiceClient$auxiliary$IGkmczwW.call(Unknown Source)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:86)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java)
at org.apache.thrift.TServiceClient.sendBaseOneway(TServiceClient.java:66)
at io.jaegertracing.agent.thrift.Agent$Client.send_emitBatch(Agent.java:70)
at io.jaegertracing.agent.thrift.Agent$Client.emitBatch(Agent.java:63)
at io.jaegertracing.thrift.internal.senders.UdpSender.send(UdpSender.java:64)
at io.jaegertracing.thrift.internal.senders.ThriftSender.flush(ThriftSender.java:110)
at io.jaegertracing.internal.reporters.RemoteReporter$FlushCommand.execute(RemoteReporter.java:157)
at io.jaegertracing.internal.reporters.RemoteReporter$QueueProcessor.run(RemoteReporter.java:176)
at java.lang.Thread.run(Thread.java:748)`
I also encountered a similar problem, for the time being can only disable the plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6064:
URL: https://github.com/apache/skywalking/issues/6064
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6064: Exception with thrift plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6064:
URL: https://github.com/apache/skywalking/issues/6064#issuecomment-750051261
And notice, our latest release is 8.3.0. The #5989 has not been released yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org