You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/06/12 21:45:39 UTC
Review Request 35400: RANGER-549 Junit test update so it would have
caught this problem.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35400/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-549
https://issues.apache.org/jira/browse/RANGER-549
Repository: ranger
Description
-------
Fix made for the bug related to comparing Long values with != instead of equal should have been caught by a test. Test did not catch it because it was setting mock values to long instead of Long. Test was changed so it would have failed with prior code.
Diffs
-----
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java 6c20f0d
Diff: https://reviews.apache.org/r/35400/diff/
Testing
-------
Confirmed that test breaks with earlier code but works with new code.
Thanks,
Alok Lal
Re: Review Request 35400: RANGER-549 Junit test update so it would
have caught this problem.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35400/#review87838
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 12, 2015, 7:45 p.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35400/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 7:45 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-549
> https://issues.apache.org/jira/browse/RANGER-549
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix made for the bug related to comparing Long values with != instead of equal should have been caught by a test. Test did not catch it because it was setting mock values to long instead of Long. Test was changed so it would have failed with prior code.
>
>
> Diffs
> -----
>
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java 6c20f0d
>
> Diff: https://reviews.apache.org/r/35400/diff/
>
>
> Testing
> -------
>
> Confirmed that test breaks with earlier code but works with new code.
>
>
> Thanks,
>
> Alok Lal
>
>