You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/14 11:20:10 UTC
[GitHub] [doris] Zasek opened a new pull request, #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
Zasek opened a new pull request, #10858:
URL: https://github.com/apache/doris/pull/10858
# Proposed changes
Issue Number: close #7570
## Problem Summary:
when parsing Array type column, get_family_name() will only return "Array". This family name is insufficient for the data type factory to choose a proper function. The data type factory requires such as "Array(Int32)" or "Array(String)". So we must use ge_name() here.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10858:
URL: https://github.com/apache/doris/pull/10858#issuecomment-1382973929
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10858:
URL: https://github.com/apache/doris/pull/10858#issuecomment-1186564136
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10858:
URL: https://github.com/apache/doris/pull/10858#issuecomment-1186564141
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10858:
URL: https://github.com/apache/doris/pull/10858#issuecomment-1186709458
@Zasek please rebase to pass p0 check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #10858: [fix](array-type) fix vec arrow scanner using wrong type when choosing cast function
URL: https://github.com/apache/doris/pull/10858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org