You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mike Kienenberger <mk...@gmail.com> on 2007/05/10 23:42:48 UTC

[Trinidad] non-"sandbox" commits should have JIRA issues

Just an FYI that the standard MyFaces practice is that all non-sandbox
commits should have JIRA issues (and references in the commit log).

This makes it easier to create release notes as well as to research
why a change was made.

Re: [Trinidad] non-"sandbox" commits should have JIRA issues

Posted by Adam Winer <aw...@gmail.com>.
OK, great!  Let me know if (or, rather, *when*) I slip again. :)

-- Adam


On 5/12/07, Mike Kienenberger <mk...@gmail.com> wrote:
> Yes, my original message said "non-trivial, non-sandbox", but when I
> typed it in again, I didn't include it.   Sorry for the confusion.
>
> On 5/12/07, Adam Winer <aw...@gmail.com> wrote:
> > I completely agree for anything non-trivial, but
> > what about comparative trivia like:
> >   - whitespace changes
> >   - deleting unused variables
> >   - fixing spelling errors
> >   - etc..
> >
> > There's no value to mentioning these in release notes,
> > and if you have a thorough SVN commit message
> > (which should always be required practice), no one
> > will wonder why it was done...  Just looking for
> > the happy medium.  If you put too much procedure
> > on checkins, then people will:
> >   - Merge two tasks into one checkin (very bad procedure)
> >   - Not even bother with simple stuff
> >
> > All that said, I absolutely should have referred
> > some checkins last week to
> > http://issues.apache.org/jira/browse/ADFFACES-135
> > Mea culpa!
> >
> > -- Adam
> >
> >
> > On 5/10/07, Mike Kienenberger <mk...@gmail.com> wrote:
> > > Just an FYI that the standard MyFaces practice is that all non-sandbox
> > > commits should have JIRA issues (and references in the commit log).
> > >
> > > This makes it easier to create release notes as well as to research
> > > why a change was made.
> > >
> >
>

Re: [Trinidad] non-"sandbox" commits should have JIRA issues

Posted by Mike Kienenberger <mk...@gmail.com>.
Yes, my original message said "non-trivial, non-sandbox", but when I
typed it in again, I didn't include it.   Sorry for the confusion.

On 5/12/07, Adam Winer <aw...@gmail.com> wrote:
> I completely agree for anything non-trivial, but
> what about comparative trivia like:
>   - whitespace changes
>   - deleting unused variables
>   - fixing spelling errors
>   - etc..
>
> There's no value to mentioning these in release notes,
> and if you have a thorough SVN commit message
> (which should always be required practice), no one
> will wonder why it was done...  Just looking for
> the happy medium.  If you put too much procedure
> on checkins, then people will:
>   - Merge two tasks into one checkin (very bad procedure)
>   - Not even bother with simple stuff
>
> All that said, I absolutely should have referred
> some checkins last week to
> http://issues.apache.org/jira/browse/ADFFACES-135
> Mea culpa!
>
> -- Adam
>
>
> On 5/10/07, Mike Kienenberger <mk...@gmail.com> wrote:
> > Just an FYI that the standard MyFaces practice is that all non-sandbox
> > commits should have JIRA issues (and references in the commit log).
> >
> > This makes it easier to create release notes as well as to research
> > why a change was made.
> >
>

Re: [Trinidad] non-"sandbox" commits should have JIRA issues

Posted by Volker Weber <v....@inexso.de>.
Hi,

thanks for this info, i just fixed a jira id this way.
Will jira get corrected automatically and move the commit from
tobago-355 to tobago-350?

Regards,
 Volker

2007/5/12, Wendy Smoak <ws...@gmail.com>:
> On 5/12/07, Adam Winer <aw...@gmail.com> wrote:
>
> > All that said, I absolutely should have referred
> > some checkins last week to
> > http://issues.apache.org/jira/browse/ADFFACES-135
> > Mea culpa!
>
> You can fix the commit log message after the fact:
>
> svn propedit --revprop -r12345 svn:log
>
> ('svn help propedit' for more info.)
>
> --
> Wendy
>

Re: [Trinidad] non-"sandbox" commits should have JIRA issues

Posted by Wendy Smoak <ws...@gmail.com>.
On 5/12/07, Adam Winer <aw...@gmail.com> wrote:

> All that said, I absolutely should have referred
> some checkins last week to
> http://issues.apache.org/jira/browse/ADFFACES-135
> Mea culpa!

You can fix the commit log message after the fact:

svn propedit --revprop -r12345 svn:log

('svn help propedit' for more info.)

-- 
Wendy

Re: [Trinidad] non-"sandbox" commits should have JIRA issues

Posted by Adam Winer <aw...@gmail.com>.
I completely agree for anything non-trivial, but
what about comparative trivia like:
  - whitespace changes
  - deleting unused variables
  - fixing spelling errors
  - etc..

There's no value to mentioning these in release notes,
and if you have a thorough SVN commit message
(which should always be required practice), no one
will wonder why it was done...  Just looking for
the happy medium.  If you put too much procedure
on checkins, then people will:
  - Merge two tasks into one checkin (very bad procedure)
  - Not even bother with simple stuff

All that said, I absolutely should have referred
some checkins last week to
http://issues.apache.org/jira/browse/ADFFACES-135
Mea culpa!

-- Adam


On 5/10/07, Mike Kienenberger <mk...@gmail.com> wrote:
> Just an FYI that the standard MyFaces practice is that all non-sandbox
> commits should have JIRA issues (and references in the commit log).
>
> This makes it easier to create release notes as well as to research
> why a change was made.
>