[GitHub] npawar opened a new pull request #3713: Move instantiation of objects which depend on _helixResourceManager to after invocation of PinotHelixResourceManager::start

[GitBox <gi...@apache.org>]

npawar opened a new pull request #3713: Move instantiation of objects which depend on _helixResourceManager to after invocation of PinotHelixResourceManager::start
URL: https://github.com/apache/incubator-pinot/pull/3713
 
 
   Certain objects which are instantiated in the `ControllerStarter` need an instance of `PinotHelixResourceManager`. Even though `PinotHelixResourceManager` is instantiated in the `ControllerStarter` constructor right at the beginning, it cannot be used until `PinotHelixResourceManager::start` is invoked. The start is invoked in `ControllerStarter::start()`. Every object that depends on `PinotHelixResourceManage`r should be created **after** this invocation of start. These include 
   1) ControllerLeadershipManager
   2) PinotHelixTaskResourceManager
   3) PeriodicTasks - RetentionManager, SegmentStatusChecker, RealtimeSegmentValidationManager, OfflineSegmentValidationManager, BrokerResourcevalidationManager, RealtimeSegmentRelocator and PinotTaskManager
   4) PinotLLCRealtimeSegmentManager, PinotRealtimeSegmentManager
   
   Of this list, some of 3 and 4 were being created before `PinotHelixResourceManager::start`.
   
   This PR moves all the dependents to after `PinotHelixResourceManager` being ready
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org