You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/06/15 02:09:19 UTC

[Impala-ASF-CR] IMPALA-9690 addendum: Add a legacy AVX mode

Hello Quanlong Huang, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17588

to look at the new patch set (#3).

Change subject: IMPALA-9690 addendum: Add a legacy AVX mode
......................................................................

IMPALA-9690 addendum: Add a legacy AVX mode

Impala 4 introduced a requirement that x86_64 machines
support AVX2. This adds a startup parameter
enable_legacy_avx_support that relaxes the AVX2 requirement
to require only AVX. By default, enable_legacy_avx_support
is false. enable_legacy_avx_support will be removed in a
future release, but it seems like a sensible way to support
older machines for now.

Testing:
  - Ran with enable_legacy_avx_support on a pool of machines
    that includes machines without AVX2
  - Ran a core job on a machine with AVX2

Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
---
M be/src/codegen/CMakeLists.txt
M be/src/codegen/impala-ir-data.h
M be/src/codegen/llvm-codegen.cc
M be/src/common/global-flags.cc
M be/src/util/cpu-info.cc
5 files changed, 82 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/17588/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44051720697a2a497f9017e4b31289be77fb6b05
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>