(couchdb) 01/01: Remove lto for quickjs

[va...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vatamane pushed a commit to branch skip-lto-for-quickjs
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 08a0ab033ca0679044591716035373f534673ae9
Author: Nick Vatamaniuc <va...@gmail.com>
AuthorDate: Fri Jun 13 12:10:31 2025 -0400

    Remove lto for quickjs
    
    It caused issues on FreeBSD before and we also noticed it failing in an RHEL
    container with this error:
    
    ```
    -lm -lpthread -ldl
    make[2]: *** write jobserver: Bad file descriptor.  Stop.
    make[2]: *** Waiting for unfinished jobs....
    make[2]: *** write jobserver: Bad file descriptor.  Stop.
    ```
    
    It seems to be due to an interaction between the `-j` flag and `CONFIG_LTO=y`.
    
    My initial thought was to remove the `-j` flag, however after running the
    quickjs `make microbench` it turns out `CONFIG_LTO=y` wasn't adding much of a
    speed up, and even was slower on Linux. So let's remove it for now and unify
    the environment with FreeBSD into a singl Unix-y env.
    
    Leave a note in the comments if something changes in the future and we wanted
    to give it another try.
---
 src/couch_quickjs/rebar.config.script | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/couch_quickjs/rebar.config.script b/src/couch_quickjs/rebar.config.script
index 60ab64070..7d53f0c47 100644
--- a/src/couch_quickjs/rebar.config.script
+++ b/src/couch_quickjs/rebar.config.script
@@ -15,8 +15,13 @@
 % Windows is "special" so we treat it "specially"
 Msys = "msys2_shell.cmd -defterm -no-start -ucrt64 -here -lc ".
 
+% Disabled CONFIG_LTO=y as of June 2025. It interfered with -j8 and microbench
+% on quickjs repo didn't show any measurable per benefit for it. It even looked
+% a bit slower on ubuntu-noble/x86_64 (lto:9032ns vs nolto:8746ns) and only a
+% tiny bit faster on MacOS x86_64 (lto:12646 vs nolto:12614)
+%
 PreHooks = [
-    {"(linux|darwin)", compile, "make CONFIG_LTO=y -C quickjs -j8 libquickjs.lto.a qjsc"},
+    {"(linux|darwin)", compile, "make -C quickjs -j8 libquickjs.a qjsc"},
     {"freebsd", compile, "gmake -C quickjs -j8 libquickjs.a qjsc"},
     {"win32", compile, Msys ++ "'make -C quickjs -j8 libquickjs.a qjsc.exe'"},
     {"(linux|darwin|freebsd|win32)", compile, "escript build_js.escript compile"}
@@ -38,12 +43,7 @@ ResetFlags = [
     {"EXE_LDFLAGS", ""}
 ].
 
-LinuxDarwinEnv = [
-    {"CFLAGS", "$CFLAGS -flto -g -Wall -DCONFIG_LTO=y -O2 -Iquickjs"},
-    {"LDFLAGS", "$LDFLAGS -flto -lm quickjs/libquickjs.lto.a"}
-] ++ ResetFlags.
-
-FreeBSDEnv  = [
+UnixEnv = [
     {"CFLAGS", "$CFLAGS -g -Wall -O2 -Iquickjs"},
     {"LDFLAGS", "$LDFLAGS -lm -lpthread quickjs/libquickjs.a"}
 ] ++ ResetFlags.
@@ -73,10 +73,8 @@ WindowsMainjsSrc = WindowsBaseSrc ++ UnixMainjsSrc.
 WindowsCoffeeSrc = WindowsBaseSrc ++ UnixCoffeeSrc.
 
 PortSpecs = [
-    {"(linux|darwin)", "priv/couchjs_mainjs", UnixMainjsSrc, [{env, LinuxDarwinEnv}]},
-    {"(linux|darwin)", "priv/couchjs_coffee", UnixCoffeeSrc, [{env, LinuxDarwinEnv}]},
-    {"freebsd", "priv/couchjs_mainjs", UnixMainjsSrc, [{env, FreeBSDEnv}]},
-    {"freebsd", "priv/couchjs_coffee", UnixCoffeeSrc, [{env, FreeBSDEnv}]},
+    {"(linux|darwin|freebsd)", "priv/couchjs_mainjs", UnixMainjsSrc, [{env, UnixEnv}]},
+    {"(linux|darwin|freebsd)", "priv/couchjs_coffee", UnixCoffeeSrc, [{env, UnixEnv}]},
     {"win32", "priv/couchjs_mainjs.exe", WindowsMainjsSrc, [{env, WindowsEnv}]},
     {"win32", "priv/couchjs_coffee.exe", WindowsCoffeeSrc, [{env, WindowsEnv}]}
 ].