You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-commits@incubator.apache.org by aw...@apache.org on 2007/05/02 00:12:44 UTC
svn commit: r534284 [1/2] - in
/incubator/adffaces/trunk/trinidad/trinidad-api/src/main:
java-templates/org/apache/myfaces/trinidad/component/
java/org/apache/myfaces/trinidad/bean/
java/org/apache/myfaces/trinidad/bean/util/ java/org/apache/myfaces/tr...
Author: awiner
Date: Tue May 1 17:12:41 2007
New Revision: 534284
URL: http://svn.apache.org/viewvc?view=rev&rev=534284
Log:
Fix Javadoc warnings
Modified:
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectManyTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOneTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOrderTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXShowDetailTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSingleStepTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTableTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTreeTableTemplate.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBean.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanFactory.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanImpl.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyKey.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyMap.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/FlaggedPropertyMap.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/ValueMap.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/AddComponentDocumentChange.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/DocumentChange.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SetFacetChildDocumentChange.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXCollection.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXFacesBean.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXHierarchy.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXMenuHierarchy.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXNavigationHierarchy.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/config/Configurator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/DialogService.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/PartialPageContext.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RenderingContext.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/ColorConverter.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/DateTimeConverter.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/NumberConverter.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/AttributeChangeListener.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/DisclosureListener.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/LaunchListener.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/RangeChangeListener.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/ReturnListener.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ProcessMenuModel.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySet.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySetTreeImpl.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ViewIdPropertyMenuModel.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/XMLMenuModel.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/render/CoreRenderer.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Icon.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Skin.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/Base64InputStream.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/FastMessageFormat.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/ByteLengthValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateRestrictionValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateTimeRangeValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DoubleRangeValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LengthValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LongRangeValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/RegExpValidator.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/webapp/ResourceServlet.java
incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/webapp/UIXComponentTag.java
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java Tue May 1 17:12:41 2007
@@ -182,7 +182,6 @@
* property is true. Iif the component is invalid afterwards or
* a <code>RuntimeException</code> is thrown, calls
* {@link FacesContext#renderResponse}.
- * @exception NullPointerException {@inheritDoc}
*/
@Override
public void processDecodes(FacesContext context)
@@ -230,9 +229,7 @@
_executeValidate(context);
}
- /**
- * @todo Better error messages when update model fails.
- */
+ // TODO Better error messages when update model fails.
public void updateModel(FacesContext context)
{
if (context == null)
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectManyTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectManyTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectManyTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectManyTemplate.java Tue May 1 17:12:41 2007
@@ -40,9 +40,9 @@
/**
* Compares two values, disregarding the order of the elements.
- * @todo walk through UIXSelectItem values to determine that new
- * values are permitted
*/
+ // TODO walk through UIXSelectItem values to determine that new
+ // values are permitted
@Override
protected void validateValue(FacesContext context, Object newValue)
{
@@ -71,10 +71,9 @@
}
/**
- *
- * @todo improve efficiency
* @return true if the values are different
*/
+ // TODO improve efficiency
@Override
protected boolean compareValues(Object previous, Object value)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOneTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOneTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOneTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOneTemplate.java Tue May 1 17:12:41 2007
@@ -26,10 +26,8 @@
static public final String REQUIRED_MESSAGE_ID =
"org.apache.myfaces.trinidad.UIXSelectOne.REQUIRED";
- /**
- * @todo walk through UIXSelectItem values to determine that the new
- * value is permitted
- */
+ // TODO walk through UIXSelectItem values to determine that the new
+ // value is permitted
@Override
public void validateValue(FacesContext context, Object newValue)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOrderTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOrderTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOrderTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSelectOrderTemplate.java Tue May 1 17:12:41 2007
@@ -25,9 +25,9 @@
/**
* Compares two values, paying attention to the order of the elements.
- * @todo improve efficiency
* @return true if the values are different
*/
+ // TODO improve efficiency for the array case?
@Override
@SuppressWarnings("unchecked")
protected boolean compareValues(Object previous, Object value)
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXShowDetailTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXShowDetailTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXShowDetailTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXShowDetailTemplate.java Tue May 1 17:12:41 2007
@@ -102,11 +102,6 @@
}
}
- /**
- * @todo Should a non-immediate ShowDetail fire after UPDATE_MODEL_VALUES,
- * or INVOKE_APPLICATION? Or should we only support non-immediate
- * ShowDetails?
- */
@Override
public void queueEvent(FacesEvent e)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSingleStepTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSingleStepTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSingleStepTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXSingleStepTemplate.java Tue May 1 17:12:41 2007
@@ -31,8 +31,6 @@
* Base class for singleStep components
*
* @version $Name: $ ($Revision$) $Date$
- * @todo =-=jmw should the text attribute be on the
- * base component?
*/
abstract public class UIXSingleStepTemplate
extends UIXComponentBase
@@ -62,9 +60,7 @@
super.queueEvent(e);
}
- /**
- * @todo Store as transient PropertyKey
- */
+ // TODO Store as transient PropertyKey
public Object getActionType()
{
return _actionType;
@@ -76,11 +72,10 @@
_actionType = actionType;
}
- /**
- * @todo if I have default listeners, then should
- * remove (then restore) default Listeners before saving state -
- * this note copied from form.submitButtonBase.saveState....
- */
+
+ // TODO if I have default listeners, then should
+ // remove (then restore) default Listeners before saving state -
+ // this note copied from form.submitButtonBase.saveState....
@Override
public Object saveState(FacesContext context)
{
@@ -124,10 +119,8 @@
return getNextAction();
}
- /**
- * @todo Either make this throw an exception, or make it
- * execute on both back and next.
- */
+ // TODO Either make this throw an exception, or make it
+ // execute on both back and next.
public void setAction(MethodBinding action)
{
if ( getActionType() == PREVIOUS_ACTION_TYPE)
@@ -144,10 +137,8 @@
return getNextActionListener();
}
- /**
- * @todo Either make this throw an exception, or make it
- * execute on both back and next.
- */
+ // TODO Either make this throw an exception, or make it
+ // execute on both back and next.
public void setActionListener(MethodBinding listener)
{
if ( getActionType() == PREVIOUS_ACTION_TYPE)
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTableTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTableTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTableTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTableTemplate.java Tue May 1 17:12:41 2007
@@ -225,8 +225,8 @@
/**
* Gets the stamps. This returns the children of this component plus
* the detail stamp (if any).
- * @todo cache the result.
*/
+ // TODO cache the result
@Override
protected final List<UIComponent> getStamps()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTreeTableTemplate.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTreeTableTemplate.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTreeTableTemplate.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXTreeTableTemplate.java Tue May 1 17:12:41 2007
@@ -41,7 +41,6 @@
* Base class for TreeTable component. The behaviours implemented by the
* TreeTable include expanding/collapsing subtrees and focusing into subtrees.
* @version $Name: $ ($Revision$) $Date$
- * @todo document new default value for formSubmitted
*/
abstract public class UIXTreeTableTemplate extends UIXTree
{
@@ -203,8 +202,8 @@
/**
* Gets the stamps. This returns the children of this component plus
* the nodeStamp stamp (if any).
- * @todo cache the result.
*/
+ // TODO cache the result.
@Override
@SuppressWarnings("unchecked")
protected final List getStamps()
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBean.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBean.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBean.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBean.java Tue May 1 17:12:41 2007
@@ -44,9 +44,9 @@
* been set for this key, that ValueBinding will be evaluated.
*
* @param key the property key
- * @todo Additional version that takes a FacesContext?
* @exception IllegalArgumentException if key is a list key
*/
+ // TODO Additional version that takes a FacesContext?
public Object getProperty(PropertyKey key);
/**
@@ -133,11 +133,11 @@
* Return as an array all elements of this key that
* are instances of the specified class.
* @return an array whose instance type is the class
- * @todo This can, of course, be implemented on top of entries();
- * consider moving to a utility function; however, it's
- * universally needed by all consumers, so...
* @exception IllegalArgumentException if the key is not a list key.
*/
+ // TODO This can, of course, be implemented on top of entries();
+ // consider moving to a utility function; however, it's
+ // universally needed by all consumers, so...
public Object[] getEntries(PropertyKey listKey, Class<?> clazz);
/**
@@ -149,9 +149,9 @@
/**
* Returns an iterator over all entries at this key.
- * @todo is this iterator read-only or read-write?
* @exception IllegalArgumentException if the key is not a list key.
*/
+ // TODO is this iterator read-only or read-write?
public Iterator<? extends Object> entries(PropertyKey listKey);
/**
@@ -188,8 +188,10 @@
public void restoreState(FacesContext context, Object state);
/**
- * @todo Extract as interface?
+ * Type of a FacesBean, encapsulating the set of registered
+ * PropertyKeys.
*/
+ // TODO Extract as interface?
public static class Type
{
public Type()
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanFactory.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanFactory.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanFactory.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanFactory.java Tue May 1 17:12:41 2007
@@ -40,8 +40,9 @@
public class FacesBeanFactory
{
/**
- * @todo change from ownerClass to componentFamily
+ * Create a FacesBean for a component class.
*/
+ // TODO change from ownerClass to componentFamily?
static public FacesBean createFacesBean(
Class<?> ownerClass,
String rendererType)
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanImpl.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanImpl.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanImpl.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/FacesBeanImpl.java Tue May 1 17:12:41 2007
@@ -45,8 +45,9 @@
}
/**
- * @todo Use auto "TYPE" detection?
+ * Get the type of a FacesBean
*/
+ // TODO Use auto "TYPE" detection?
abstract public Type getType();
final public Object getProperty(PropertyKey key)
@@ -89,12 +90,10 @@
}
- /**
- * @todo Need *good* way of hooking property-sets; it's
- * currently not called from state restoring, so really, it shouldn't
- * be used as a hook, but EditableValueBase currently
- * requires hooking this method.
- */
+ // TODO Need *good* way of hooking property-sets; it's
+ // currently not called from state restoring, so really, it shouldn't
+ // be used as a hook, but EditableValueBase currently
+ // requires hooking this method.
public void setProperty(PropertyKey key, Object value)
{
_checkNotListKey(key);
@@ -234,10 +233,8 @@
return l.iterator();
}
- /**
- * @todo provide more efficient implementation for copying
- * from other FacesBeanImpl instances
- */
+ // TODO provide more efficient implementation for copying
+ // from other FacesBeanImpl instances
public void addAll(FacesBean from)
{
if (from == this)
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyKey.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyKey.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyKey.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyKey.java Tue May 1 17:12:41 2007
@@ -28,11 +28,6 @@
/**
* Key for an entry in a FacesBean.
- *
- *
- * @todo default values?
- * @todo some deeper concept of type?
- * @todo can list entries ensure that
*/
public class PropertyKey
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyMap.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyMap.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyMap.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/PropertyMap.java Tue May 1 17:12:41 2007
@@ -22,10 +22,8 @@
import javax.faces.context.FacesContext;
-/**
- * @todo Make "stateHolder" a generic property of all PropertyMaps?
- * If so, tweak StateUtils accordingly
- */
+// TODO Make "stateHolder" a generic property of all PropertyMaps?
+// If so, tweak StateUtils accordingly
public interface PropertyMap extends Map<PropertyKey,Object>
{
public void markInitialState();
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/FlaggedPropertyMap.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/FlaggedPropertyMap.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/FlaggedPropertyMap.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/FlaggedPropertyMap.java Tue May 1 17:12:41 2007
@@ -148,9 +148,7 @@
return map.entrySet();
}
- /**
- * @todo Optimize to take advantage of flags.
- */
+ // TODO Optimize to take advantage of flags.
@Override
public Set<PropertyKey> keySet()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/ValueMap.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/ValueMap.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/ValueMap.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/bean/util/ValueMap.java Tue May 1 17:12:41 2007
@@ -77,9 +77,7 @@
return _putInternal(_getPropertyKey(key), value);
}
- /**
- * @todo Should remove just remove values, or also remove bindings?
- */
+ // TODO Should remove just remove values, or also remove bindings?
@Override
public Object remove(Object key)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/AddComponentDocumentChange.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/AddComponentDocumentChange.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/AddComponentDocumentChange.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/AddComponentDocumentChange.java Tue May 1 17:12:41 2007
@@ -62,7 +62,6 @@
* Given the target Node, return the DocumentFragment, imported into the
* target Document
* @param targetNode
- * @return
*/
protected final DocumentFragment getImportedComponentFragment(Node targetNode)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java Tue May 1 17:12:41 2007
@@ -43,10 +43,8 @@
{
/**
* {@inheritDoc}
- *
- * @todo =-=pu : Maybe we need to allow adding Changes for specific viewId's -
- * BIBeans req. - external customizer dialog
*/
+ // TODO : Maybe we need to allow adding Changes for specific viewId's
@Override
public void addComponentChange(
FacesContext facesContext,
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/DocumentChange.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/DocumentChange.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/DocumentChange.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/DocumentChange.java Tue May 1 17:12:41 2007
@@ -30,7 +30,7 @@
{
/**
* Apply this change to the specied root DOM Node of the component
- * @param Root DOM node of the component to apply the change to
+ * @param componentNode DOM node of the component to apply the change to
*/
public void changeDocument(Node componentNode);
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SetFacetChildDocumentChange.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SetFacetChildDocumentChange.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SetFacetChildDocumentChange.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SetFacetChildDocumentChange.java Tue May 1 17:12:41 2007
@@ -35,7 +35,7 @@
* Constructs an AddFacetDocumentChange with the specified child component mark up and
* the name of the facet.
* @param facetName Name of facet to create the child component in
- * @param componentFragment DOM mark up for child component to be inserted.
+ * @param fragment DOM mark up for child component to be inserted.
* @throws IllegalArgumentException if facetName or componentFragment is
* <code>null</code>
*/
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXCollection.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXCollection.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXCollection.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXCollection.java Tue May 1 17:12:41 2007
@@ -945,8 +945,8 @@
/**
* Gets the ClientRowKeyManager that is used to handle the
- * @{link #getClientRowKey} and
- * @{link #setClientRowKey} methods.
+ * {@link #getClientRowKey} and
+ * {@link #setClientRowKey} methods.
* If the manager does not already exist a new one is created.
* In order to create your own manager, your Renderer (for this component)
* must implement
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java Tue May 1 17:12:41 2007
@@ -79,10 +79,9 @@
* markInitialState() - can offer major state saving improvements.
* </ul>
* </p>
- * @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/component/UIXComponentBase.java#0 $) $Date: 11-nov-2005.13:43:35 $
- * @todo Write Class Javadoc
- * @todo Thorough review against UIComponentBase
*/
+// TODO Write Class Javadoc
+// TODO Thorough review against UIComponentBase
abstract public class UIXComponentBase extends UIXComponent
{
// Created up top to ensure it's present while we're processing
@@ -389,9 +388,6 @@
}
- /**
- * @todo Pass through to Renderer
- */
@Override
public boolean getRendersChildren()
{
@@ -409,9 +405,6 @@
- /**
- * @exception NullPointerException {@inheritDoc}
- */
@Override
public UIComponent findComponent(String id)
{
@@ -549,9 +542,7 @@
}
- /**
- * @todo optimize to a compound iterator
- */
+ // TODO: Optimize to a compound iterator
@SuppressWarnings("unchecked")
@Override
public Iterator getFacetsAndChildren()
@@ -723,10 +714,6 @@
__encodeRecursive(context, this);
}
- /**
- * @exception IllegalStateException {@inheritDoc}
- * @exception NullPointerException {@inheritDoc}
- */
@Override
public void queueEvent(FacesEvent event)
{
@@ -810,13 +797,10 @@
}
}
- /**
- *
- * @todo will have deep problems if UIComponent.saveState() ever
- * returns a String.
- * @todo crashes and burns if there are fewer children or missing
- * facets from when state was saved.
- */
+ // TODO will have deep problems if UIComponent.saveState() ever
+ // returns a String.
+ // TODO crashes and burns if there are fewer children or missing
+ // facets from when state was saved.
@Override
public void processRestoreState(FacesContext context, Object state)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXFacesBean.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXFacesBean.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXFacesBean.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXFacesBean.java Tue May 1 17:12:41 2007
@@ -21,11 +21,13 @@
import org.apache.myfaces.trinidad.bean.FacesBean;
/**
- * @todo Strongly consider merging this into FacesBean!
+ * Subinterface for FacesBeans that are used for the storage
+ * of a UIXComponent.
*/
public interface UIXFacesBean extends FacesBean
{
/**
+ * Initialize a UIXFacesBean with a specific component and type.
*/
public void init(
UIXComponent component,
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXHierarchy.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXHierarchy.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXHierarchy.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXHierarchy.java Tue May 1 17:12:41 2007
@@ -59,10 +59,10 @@
}
/**
- * @todo implement this
* Gets the index of the first visible row in this tree
* @return zero-based index. not implemented yet.
*/
+ // TODO implement this
public int getFirst()
{
return 0;
@@ -71,8 +71,8 @@
/**
* Gets the maximum number of rows that this tree should show at a time.
* @return not implemented yet.
- * @todo implement this
*/
+ // TODO implement this
public int getRows()
{
return 0;
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXMenuHierarchy.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXMenuHierarchy.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXMenuHierarchy.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXMenuHierarchy.java Tue May 1 17:12:41 2007
@@ -24,9 +24,8 @@
* Work on modeling menus continues and it is very possible that this class
* will change in a future release.
*
- * @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/component/UIXMenuHierarchy.java#0 $) $Date: 10-nov-2005.19:09:52 $
- * @todo these base classes need to be completely refactored
*/
+// TODO these base classes need to be completely refactored
abstract public class UIXMenuHierarchy extends UIXHierarchy
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXNavigationHierarchy.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXNavigationHierarchy.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXNavigationHierarchy.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/UIXNavigationHierarchy.java Tue May 1 17:12:41 2007
@@ -28,10 +28,8 @@
* <p>
* Work on modeling navigation continues and it is very possible that this class
* will change in a future release.
- *
- * @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/component/UIXNavigationHierarchy.java#0 $) $Date: 10-nov-2005.19:09:52 $
- * @todo these base classes need to be completely refactored
*/
+// TODO these base classes need to be completely refactored
abstract public class UIXNavigationHierarchy extends UIXHierarchy
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/config/Configurator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/config/Configurator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/config/Configurator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/config/Configurator.java Tue May 1 17:12:41 2007
@@ -54,7 +54,7 @@
* any other method within this Configurator and will be called only once
* per webapp context. This init is guaranteed to be executed before
* completion of the first call to the
- * {@link javax.faces.FacesContextFactory#getFacesContext(Object, Object, Object,javax.faces.lifecycle.Lifecycle)}
+ * {@link javax.faces.context.FacesContextFactory#getFacesContext}
* is completed.
*
* <strong>Note:</strong>the ExternalContext provided to this method may not
@@ -79,7 +79,7 @@
/**
* This is called at the beginning of each "physical" request, sometime
* before {@link #getExternalContext(ExternalContext)} or
- * {@link #endRequestRequest(ExternalContext)}. When using the
+ * {@link #endRequest(ExternalContext)}. When using the
* TrinidadFilter, this will be called during filter execution, but
* is not guaranteed to happen until just before the creation of the
* Trinidad FacesContext wrapper.
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/DialogService.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/DialogService.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/DialogService.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/DialogService.java Tue May 1 17:12:41 2007
@@ -134,7 +134,7 @@
* This method should only be used by controller framework
* code; all others should use
* {@link RequestContext#launchDialog RequestContext.launchDialog()}.
- * The process scope must be {@link #pushPageFlowScope pushed}
+ * The process scope must be {@link PageFlowScopeProvider#pushPageFlowScope pushed}
* <em>before</em> calling this method.
*/
public abstract void launchDialog(
@@ -150,7 +150,7 @@
* This method should only be used by controller framework
* code; all others should use
* {@link RequestContext#returnFromDialog RequestContext.returnFromDialog()}.
- * The process scope must be {@link #popPageFlowScope popped}
+ * The process scope must be {@link PageFlowScopeProvider#popPageFlowScope popped}
* <em>after</em> calling this method.
*
* @return true if pages accessing that dialog are necessarily permanently
@@ -166,7 +166,7 @@
* Queues a LaunchEvent that will result in a dialog being started, using
* {@link #getCurrentLaunchSource current launch source} as the source
* for launching the dialogRoot parameter.
- * The process scope must be {@link #pushPageFlowScope pushed}
+ * The process scope must be {@link PageFlowScopeProvider#pushPageFlowScope pushed}
* <em>before</em> calling this method. If {@link #getCurrentLaunchSource}
* returns <code>null</code>, a basic dialog will be started without
* using a window or passing any additional parameters. Developers
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/PartialPageContext.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/PartialPageContext.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/PartialPageContext.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/PartialPageContext.java Tue May 1 17:12:41 2007
@@ -63,12 +63,8 @@
* <p>
* This method may be called during the partial rendering pass to
* add to the set of partial targets, but only if the pass has
- * not yet been completed. Clients should first check to see
- * whether the partial rendering pass has finished by calling
- * isPartialPassComplete() before calling this method.
- *
+ * not yet been completed.
* @param id The id of the partial target to render
- * @see #isPartialPassComplete
*/
abstract public void addPartialTarget(String id);
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RenderingContext.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RenderingContext.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RenderingContext.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RenderingContext.java Tue May 1 17:12:41 2007
@@ -93,10 +93,8 @@
abstract public String getOutputMode();
abstract public RequestContext.Accessibility getAccessibilityMode();
- /**
- * @TODO This is a hack API to enable caching of the client ID.
- * All fine, but we should have a more general mechanism.
- */
+ // TODO This is a hack API to enable caching of the client ID.
+ // All fine, but we should have a more general mechanism.
public String getCurrentClientId() { return _currentClientId; }
public void setCurrentClientId(String currentClientId)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java Tue May 1 17:12:41 2007
@@ -44,13 +44,11 @@
* as extending <code>FacesContext</code> requires taking over the
* <code>FacesContextFactory</code>.
* <p>
- *
- * @todo Refactor this class after everything gets added to it.
- * @todo There's some values in here that seem to affect only output (e.g.,
- * right-to-left); that's not great, since ideally that detail would be
- * buried in something more renderer-specific.
- * @mock
*/
+// TODO Refactor this class after everything gets added to it.
+// TODO There's some values in here that seem to affect only output (e.g.,
+// right-to-left); that's not great, since ideally that detail would be
+// buried in something more renderer-specific.
abstract public class RequestContext
{
/**
@@ -123,9 +121,9 @@
* <p>
* @see org.apache.myfaces.trinidad.event.ReturnEvent
* @param returnValue the value to be delivered in the the ReturnEvent
- * @todo Do I need an explicit "cancelled" concept, or
- * is a null returnValue good enough?
*/
+ // TODO Do we need an explicit "cancelled" concept, or
+ // is a null returnValue good enough?
public abstract void returnFromDialog(
Object returnValue,
Map<Object, Object> returnParameters);
@@ -282,9 +280,8 @@
* currency fields when those fields do not specify an explicit
* currency field via their converter. If this returns null, the default
* code for the current locale will be used.
- *
- * @todo Investigate if we need to provide getCurrencySymbol() as well.
*/
+ // TODO do we need to provide getCurrencySymbol() as well?
public abstract String getCurrencyCode();
//
@@ -304,9 +301,8 @@
/**
* Return the URL to an Oracle Help for the Web servlet.
- * @todo Do we need to support non-OHW help systems as first-class
- * help providers?
*/
+ // TODO Add support for non-OHW help systems
public abstract String getOracleHelpServletUrl();
/**
@@ -411,7 +407,7 @@
* Object will be serializable, unless a UIComponent
* in this tree contains a non-serializable property. This
* method does not check that condition.
- * @param UIComponent the component
+ * @param component the component
* @return an Object that can be passed to restoreComponent()
* to reinstantiate the state
*/
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/ColorConverter.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/ColorConverter.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/ColorConverter.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/ColorConverter.java Tue May 1 17:12:41 2007
@@ -93,7 +93,7 @@
* {@link ConverterException} containing a {@link #CONVERT_MESSAGE_ID} message.
* The detail message of {@link #CONVERT_MESSAGE_ID} can be overridden
* by setting a custom error message, by calling
- * method <code>setConvertMessageDetail()</code>. The custom message
+ * method <code>setMessageDetailConvert()</code>. The custom message
* can contain placeholders as specified in {@link #CONVERT_MESSAGE_ID}.
* The placeholders will be replaced by appropriate values as mentioned
* in {@link #CONVERT_MESSAGE_ID}</li>
@@ -450,7 +450,7 @@
* Return custom detail error message that was set for creating faces message,
* for values that cannot be converted to {@link java.awt.Color}
* @return Custom error message.
- * @see #setConvertMessageDetail(String)
+ * @see #setMessageDetailConvert(String)
*/
public String getMessageDetailConvert()
{
@@ -470,7 +470,7 @@
/**
* <p>Return custom hint message.</p>
* @return Custom hint message.
- * @see #setHintFormat(String)
+ * @see #setHint(String)
*/
public String getHint()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/DateTimeConverter.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/DateTimeConverter.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/DateTimeConverter.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/DateTimeConverter.java Tue May 1 17:12:41 2007
@@ -100,9 +100,9 @@
* <p>The methods used for customizing the detail message associated with each id
* is given below:</p>
* <ol>
- * <li>{@link #CONVERT_DATE_MESSAGE_ID} - {@link #setConvertDateMessageDetail(String)}</li>
- * <li>{@link #CONVERT_TIME_MESSAGE_ID} - {@link #setConvertTimeMessageDetail(String) }</li>
- * <li>{@link #CONVERT_BOTH_MESSAGE_ID} - {@link #setConvertBothMessageDetail(String) }</li>
+ * <li>{@link #CONVERT_DATE_MESSAGE_ID} - {@link #setMessageDetailConvertDate(String)}</li>
+ * <li>{@link #CONVERT_TIME_MESSAGE_ID} - {@link #setMessageDetailConvertTime(String) }</li>
+ * <li>{@link #CONVERT_BOTH_MESSAGE_ID} - {@link #setMessageDetailConvertBoth(String) }</li>
* </ol> The custom messages can contain placeholders, which will be replaced with
* values as specified in its corresponding message id.
*
@@ -362,7 +362,7 @@
* <code>pattern / secondary pattern</code> is set or
* when <code>type</code> is set to <code>'date'</code>.</p>
* @return custom error message that was set.
- * @see #setConvertDateMessageDetail(String)
+ * @see #setMessageDetailConvertDate(String)
*/
public String getMessageDetailConvertDate()
{
@@ -387,7 +387,7 @@
* for values that cannot be converted to {@link java.util.Date}
* when <code>type</code> is set to <code>'time'</code>.
* @return custom error message that was set.</p>
- * @see #setConvertTimeMessageDetail(java.lang.String)
+ * @see #setMessageDetailConvertTime(java.lang.String)
*/
public String getMessageDetailConvertTime()
{
@@ -413,7 +413,7 @@
* for values that cannot be converted to {@link java.util.Date}
* when <code>type</code> is set to <code>'both'</code>.
* @return custom error message that was set.
- * @see #setConvertBothMessageDetail(java.lang.String)
+ * @see #setMessageDetailConvertBoth(java.lang.String)
*/
public String getMessageDetailConvertBoth()
{
@@ -466,7 +466,7 @@
/**
* <p>Custom hintBoth message.</p>
* Overrides default hint message
- * @param hintBotht Custom hint message.
+ * @param hintBoth Custom hint message.
*/
public void setHintBoth(String hintBoth)
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/NumberConverter.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/NumberConverter.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/NumberConverter.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/convert/NumberConverter.java Tue May 1 17:12:41 2007
@@ -86,7 +86,7 @@
* // appropriately as specified in the documentation for the corresponding
* // message id.
*
- * <code>setConvertNumberMessageDetail(convertNumberMessageDetail);</code>
+ * <code>setMessageDetailConvertNumber(convertNumberMessageDetail);</code>
*
* This way user can override detail part of the {@link FacesMessage} for
* different conversion errors that occur for wrong values, that arise
@@ -95,10 +95,10 @@
* There is a one to one mapping for message customization which is as given below. <p>The methods used for customizing the detail message associated with each id
* is given below:</p>
* <ol><code>
- * <li>{@link #CONVERT_PATTERN_MESSAGE_ID} - {@link #setConvertPatternMessageDetail(String)}</li>
- * <li>{@link #CONVERT_NUMBER_MESSAGE_ID} - {@link #setConvertNumberMessageDetail(String)}</li>
- * <li>{@link #CONVERT_CURRENCY_MESSAGE_ID} - {@link #setConvertCurrencyMessageDetail(String)}</li>
- * <li>{@link #CONVERT_PERCENT_MESSAGE_ID} - {@link #setConvertPercentMessageDetail(String)}</li>
+ * <li>{@link #CONVERT_PATTERN_MESSAGE_ID} - {@link #setMessageDetailConvertPattern(String)}</li>
+ * <li>{@link #CONVERT_NUMBER_MESSAGE_ID} - {@link #setMessageDetailConvertNumber(String)}</li>
+ * <li>{@link #CONVERT_CURRENCY_MESSAGE_ID} - {@link #setMessageDetailConvertCurrency(String)}</li>
+ * <li>{@link #CONVERT_PERCENT_MESSAGE_ID} - {@link #setMessageDetailConvertPercent(String)}</li>
* </code></ol>The custom messages can contain placeholders, which will be replaced with
* values as specified in its corresponding message id.
*
@@ -183,10 +183,6 @@
* Values having more than one decimal seprator like <code>22.22.22</code>
* and values of the form <code>22ABC, 22%ABC</code> will result in
* {@link javax.faces.convert.ConverterException}.
- *
- * @exception NullPointerException {@inheritDoc}
- * @exception ConverterException {@inheritDoc}
- *
*/
@Override
public Object getAsObject(
@@ -379,7 +375,7 @@
* Custom detail error message that was set for creation of {@link FacesMessage}
* when conversion fails for values that does not match the pattern set.
* @return Custom error message.
- * @see #setConvertPatternMessageDetail(String)
+ * @see #setMessageDetailConvertPattern(String)
*
*/
public String getMessageDetailConvertPattern()
@@ -406,7 +402,7 @@
* when conversion fails for values, when <code>type</code> is set to <code>'number'</code> and
* <code>pattern</code> is null or not set.</p>
* @return Custom error message.
- * @see #setConvertNumberMessageDetail(String)
+ * @see #setMessageDetailConvertNumber(String)
*/
public String getMessageDetailConvertNumber()
{
@@ -433,7 +429,7 @@
* when conversion fails for values, when <code>type</code> is set to
* <code>'currency'</code> and <code>pattern</code> is null or not set.</p>
* @return Custom error message.
- * @see #setConvertCurrencyMessageDetail(String)
+ * @see #setMessageDetailConvertCurrency(String)
*/
public String getMessageDetailConvertCurrency()
{
@@ -460,7 +456,7 @@
* number, when <code>type</code> is set to <code>'percent'</code>
* and <code>pattern</code> is null or not set.</p>
* @return Custom error message.
- * @see #setConvertPercentMessageDetail(String)
+ * @see #setMessageDetailConvertPercent(String)
*/
public String getMessageDetailConvertPercent()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/AttributeChangeListener.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/AttributeChangeListener.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/AttributeChangeListener.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/AttributeChangeListener.java Tue May 1 17:12:41 2007
@@ -26,7 +26,6 @@
* Listener for AttributeChangeEvents.
* <p>
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/event/AttributeChangeListener.java#0 $) $Date: 10-nov-2005.19:08:59 $
- * @mock
*/
public interface AttributeChangeListener extends FacesListener
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/DisclosureListener.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/DisclosureListener.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/DisclosureListener.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/DisclosureListener.java Tue May 1 17:12:41 2007
@@ -26,7 +26,6 @@
* Listener for DisclosureEvents.
* <p>
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/event/DisclosureListener.java#0 $) $Date: 10-nov-2005.19:09:01 $
- * @mock
*/
public interface DisclosureListener extends FacesListener
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/LaunchListener.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/LaunchListener.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/LaunchListener.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/LaunchListener.java Tue May 1 17:12:41 2007
@@ -26,7 +26,6 @@
* Listener for LaunchEvents.
* <p>
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/event/LaunchListener.java#0 $) $Date: 10-nov-2005.19:09:03 $
- * @mock
*/
public interface LaunchListener extends FacesListener
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/RangeChangeListener.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/RangeChangeListener.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/RangeChangeListener.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/RangeChangeListener.java Tue May 1 17:12:41 2007
@@ -26,7 +26,6 @@
* Listener for RangeChangedEvents.
* <p>
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/event/RangeChangeListener.java#0 $) $Date: 10-nov-2005.19:09:05 $
- * @mock
*/
public interface RangeChangeListener extends FacesListener
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/ReturnListener.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/ReturnListener.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/ReturnListener.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/event/ReturnListener.java Tue May 1 17:12:41 2007
@@ -26,7 +26,6 @@
* Listener for ReturnEvents.
* <p>
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/event/ReturnListener.java#0 $) $Date: 10-nov-2005.19:09:06 $
- * @mock
*/
public interface ReturnListener extends FacesListener
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ProcessMenuModel.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ProcessMenuModel.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ProcessMenuModel.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ProcessMenuModel.java Tue May 1 17:12:41 2007
@@ -207,8 +207,6 @@
* For the Plus One case, a stop is considered visited if,
* - it's before the current or,
* - is the current stop itself
- *
- * @return
*/
public boolean isVisited()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySet.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySet.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySet.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySet.java Tue May 1 17:12:41 2007
@@ -26,7 +26,7 @@
* This class is meant to be used with models that have a current rowKey concept.
* Therefore, the {@link #add()}, {@link #remove()} and {@link #isContained} methods
* do not need to take the rowKey as an argument, since the rowKey is implied.
- * The implied key is obtained by calling {@link #getCollectionModel.getRowKey()}
+ * The implied key is obtained by calling {@link #getCollectionModel}.getRowKey()
* <P>
* Because this Set has a reference to the underlying model, operations like
* {@link #addAll()}, {@link #removeAll()} and {@link #invertAll()} may
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySetTreeImpl.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySetTreeImpl.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySetTreeImpl.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/RowKeySetTreeImpl.java Tue May 1 17:12:41 2007
@@ -99,7 +99,7 @@
/**
* Removes the given rowKey from this Set.
* @return false if the given rowKey was already not in this Set.
- * @see #add(E)
+ * @see #add
* @see #removeAll()
*/
@Override
@@ -111,7 +111,7 @@
/**
* Adds the current rowKey and all rowKeys beneath the current rowKey to this Set.
* This method executes in constant time.
- * @see #add(E)
+ * @see #add
* @see #removeAll()
*/
@Override
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ViewIdPropertyMenuModel.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ViewIdPropertyMenuModel.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ViewIdPropertyMenuModel.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/ViewIdPropertyMenuModel.java Tue May 1 17:12:41 2007
@@ -57,9 +57,8 @@
* TreeModel treeModel = new ChildPropertyTreeModel(collectionModel, "children");
* MenuModel menuModel = new ViewIdPropertyMenuModel(treeModel, "viewId");
* </code></pre>
- *
- * @todo - support for mutable trees?
*/
+// TODO - support for mutable trees?
public class ViewIdPropertyMenuModel extends BaseMenuModel
{
/**
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/XMLMenuModel.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/XMLMenuModel.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/XMLMenuModel.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/model/XMLMenuModel.java Tue May 1 17:12:41 2007
@@ -155,7 +155,7 @@
* Makes the TreeModel part of the menu model. Also creates the
* _viewIdFocusPathMap, _nodeFocusPathMap, and idNodeMaps.
*
- * @param data. The Tree Model instance
+ * @param data The Tree Model instance
*/
@Override
public void setWrappedData(Object data)
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/render/CoreRenderer.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/render/CoreRenderer.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/render/CoreRenderer.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/render/CoreRenderer.java Tue May 1 17:12:41 2007
@@ -41,9 +41,7 @@
*/
public class CoreRenderer extends Renderer
{
- /**
- * @todo Move elsewhere?
- */
+ // TODO Move elsewhere?
static public final char CHAR_UNDEFINED = (char) -1;
static public final int NO_CHILD_INDEX = -1;
@@ -305,9 +303,6 @@
}
}
- /**
- * @todo Fix reference to CoreRenderer
- */
protected void delegateRenderer(
FacesContext context,
RenderingContext arc,
@@ -325,9 +320,6 @@
}
}
- /**
- * @todo Fix reference to CoreRenderer
- */
protected void delegateRendererBegin(
FacesContext context,
RenderingContext arc,
@@ -345,9 +337,6 @@
}
}
- /**
- * @todo Fix reference to CoreRenderer
- */
protected void delegateRendererEnd(
FacesContext context,
RenderingContext arc,
@@ -393,8 +382,8 @@
/**
* Returns true if the component should render an ID. Components
* that deliver events should always return "true".
- * @todo Is this a bottleneck? If so, optimize!
*/
+ // TODO Is this a bottleneck? If so, optimize!
protected boolean shouldRenderId(
FacesContext context,
UIComponent component)
@@ -612,7 +601,7 @@
* be reused! Each styleclass will be passed through the RenderingContext
* getStyleClass() API.
* @param context the FacesContext
- * @param styleClass the style class
+ * @param styleClasses the style classes
*/
static public void renderStyleClasses(
FacesContext context,
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Icon.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Icon.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Icon.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Icon.java Tue May 1 17:12:41 2007
@@ -58,8 +58,8 @@
/**
* Renders the Icon.
*
- * @param FacesContext context
- * @param RenderingContext arc The RenderingContext for the
+ * @param context FacesContext
+ * @param arc The RenderingContext for the
* current request.
* @param attrs A Map which which provides access to
* values that might be useful to Icon implementations,
@@ -76,8 +76,8 @@
* The default implementation of this method simply returns null,
* which indicates to the caller that no image representation of
* the Icon is available.
- * @param FacesContext context
- * @param RenderingContext arc The RenderingContext for the
+ * @param context FacesContext
+ * @param arc The RenderingContext for the
* current request.
*/
public Object getImageURI(
@@ -92,7 +92,7 @@
* The default implementation of this method simply returns null,
* which indicates to the caller the width of the image is not
* known - or that the Icon does not provide an image representation.
- * @param RenderingContext arc
+ * @param arc RenderingContext
*/
public Integer getImageWidth(RenderingContext arc)
{
@@ -104,7 +104,7 @@
* The default implementation of this method simply returns null,
* which indicates to the caller the height of the image is not
* known - or that the Icon does not provide an image representation.
- * @param RenderingContext arc
+ * @param arc RenderingContext
*
*/
public Integer getImageHeight(RenderingContext arc)
@@ -115,11 +115,11 @@
/**
* Returns an InputStream which provides access to the
* image data for image-based Icons.
- * @param FacesContext context
- * @param RenderingContext arc The RenderingContext for the
+ * @param context FacesContext
+ * @param arc The RenderingContext for the
* current request.
- * @todo Is this still necessary?
*/
+ // TODO: Delete if unnecessary
public InputStream openStream(
FacesContext context,
RenderingContext arc
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Skin.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Skin.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Skin.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/skin/Skin.java Tue May 1 17:12:41 2007
@@ -27,10 +27,8 @@
/**
* Defines the components (icons, styles, etc)
* which are used to implement a particular skin.
- * @todo. look through UIExtension comments.
*
* @see SkinFactory
- * @see org.apache.myfaces.trinidadinternal.ui.UIXRenderingContext#getSkinFactory
*
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-impl/src/main/java/oracle/adfinternal/view/faces/skin/Skin.java#0 $) $Date: 10-nov-2005.18:58:54 $
*/
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/Base64InputStream.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/Base64InputStream.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/Base64InputStream.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/Base64InputStream.java Tue May 1 17:12:41 2007
@@ -30,8 +30,6 @@
* It takes a Reader as its single argument to its constructor and base64
* characters read in from the Reader are correspondingly made available to be
* read out in the corresponding binary format via the read() method.
- *
- * @version
*/
public class Base64InputStream extends InputStream
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/FastMessageFormat.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/FastMessageFormat.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/FastMessageFormat.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/FastMessageFormat.java Tue May 1 17:12:41 2007
@@ -41,9 +41,9 @@
* </pre>
* <p>
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/util/FastMessageFormat.java#0 $) $Date: 10-nov-2005.19:08:37 $
- * @todo This class to be made public once we figure out a way to do so.
- * This class is also availble in impl for laf strings.
*/
+// TODO This class to be made public once we figure out whether we should
+// This class is also availble in impl for laf strings.
class FastMessageFormat
{
/**
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/ByteLengthValidator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/ByteLengthValidator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/ByteLengthValidator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/ByteLengthValidator.java Tue May 1 17:12:41 2007
@@ -68,7 +68,7 @@
* which will be replaced as specified in {@link #MAXIMUM_MESSAGE_ID}
* </li>
* </ul>
- * @see #setMaximumMessageDetail(String)
+ * @see #setMessageDetailMaximum(String)
*
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/validator/ByteLengthValidator.java#0 $) $Date: 10-nov-2005.19:08:32 $
*/
@@ -170,7 +170,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for values that exceeds the maximum byte length.</p>
* @return Custom error message.
- * @see #setMaximumMessageDetail(String)
+ * @see #setMessageDetailMaximum(String)
*/
public String getMessageDetailMaximum()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateRestrictionValidator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateRestrictionValidator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateRestrictionValidator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateRestrictionValidator.java Tue May 1 17:12:41 2007
@@ -158,7 +158,7 @@
/**
* <p>Custom hint invalidDaysOfWeek message.</p>
* Overrides default hint message
- * @param hintInvalidDaysOfWeek Custom hint message.
+ * @param hintWeek Custom hint message.
*/
public void setHintInvalidDaysOfWeek(String hintWeek)
{
@@ -179,7 +179,7 @@
/**
* <p>Custom hint invalidMonths message.</p>
* Overrides default hint message
- * @param hintInvalidMonths Custom hint message.
+ * @param hintMonth Custom hint message.
*/
public void setHintInvalidMonths(String hintMonth)
{
@@ -198,8 +198,6 @@
}
/**
- * @exception NullPointerException {@inheritDoc}
- * @exception ValidatorException {@inheritDoc}
* @exception IllegalArgumentException if <code>value</code> is not of type
* {@link java.util.Date}
*/
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateTimeRangeValidator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateTimeRangeValidator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateTimeRangeValidator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DateTimeRangeValidator.java Tue May 1 17:12:41 2007
@@ -65,17 +65,17 @@
* <p>The methods used for customizing the detail message associated with each id
* is given below:</p>
* <ul>
- * <li>{@link #MAXIMUM_MESSAGE_ID} - {@link #setMaximumMessageDetail(String)}</li>
- * <li>{@link #MINIMUM_MESSAGE_ID} - {@link #setMinimumMessageDetail(String)}</li>
- * <li>{@link #NOT_IN_RANGE_MESSAGE_ID} - {@link #setNotInRangeMessageDetail(String)} - </li></ul>
+ * <li>{@link #MAXIMUM_MESSAGE_ID} - {@link #setMessageDetailMaximum(String)}</li>
+ * <li>{@link #MINIMUM_MESSAGE_ID} - {@link #setMessageDetailMinimum(String)}</li>
+ * <li>{@link #NOT_IN_RANGE_MESSAGE_ID} - {@link #setMessageDetailNotInRange(String)} - </li></ul>
* Then this message will be used to construct faces message
* when validation fails based on the above-mentioned algorithm
* @version $Name: $ ($Revision: adfrt/faces/adf-faces-api/src/main/java/oracle/adf/view/faces/validator/DateTimeRangeValidator.java#0 $) $Date: 10-nov-2005.19:08:33 $
- * @todo The error message date/time reads
- * "Date cannot be before Mon Feb 16 16:11:13 PST 2004", in a perfect the
- * date should probably be in the format of the converter....
*/
+// TODO The error message date/time reads
+// "Date cannot be before Mon Feb 16 16:11:13 PST 2004", but the
+// date should probably be in the format of the converter....
public class DateTimeRangeValidator implements Validator, StateHolder {
@@ -212,7 +212,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where input value exceeds the <code>maximum</code> value set.</p>
* @return Custom error message.
- * @see #setMaximumMessageDetail(String)
+ * @see #setMessageDetailMaximum(String)
*/
public String getMessageDetailMaximum()
{
@@ -236,7 +236,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where, input value is less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setMinimumMessageDetail(String)
+ * @see #setMessageDetailMinimum(String)
*/
public String getMessageDetailMinimum()
{
@@ -261,7 +261,7 @@
* for cases where, input value exceeds the <code>maximum</code> value and is
* less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setNotInRangeMessageDetail(String)
+ * @see #setMessageDetailNotInRange(String)
*/
public String getMessageDetailNotInRange()
{
@@ -324,7 +324,7 @@
/**
* <p>Return custom hint notInRange message.</p>
* @return Custom hint message.
- * @see #setHintNotInRangeString)
+ * @see #setHintNotInRange(String)
*/
public String getHintNotInRange()
{
@@ -333,8 +333,6 @@
}
/**
- * @exception NullPointerException {@inheritDoc}
- * @exception ValidatorException {@inheritDoc}
* @exception IllegalArgumentException if <code>value</code> is not of type
* {@link java.util.Date}
*/
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DoubleRangeValidator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DoubleRangeValidator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DoubleRangeValidator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/DoubleRangeValidator.java Tue May 1 17:12:41 2007
@@ -173,7 +173,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where input value exceeds the <code>maximum</code> value set.</p>
* @return Custom error message.
- * @see #setMaximumMessageDetail(String)
+ * @see #setMessageDetailMaximum(String)
*/
public String getMessageDetailMaximum()
{
@@ -197,7 +197,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where, input value is less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setMinimumMessageDetail(String)
+ * @see #setMessageDetailMinimum(String)
*/
public String getMessageDetailMinimum()
{
@@ -222,7 +222,7 @@
* for cases where, input value exceeds the <code>maximum</code> value and is
* less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setNotInRangeMessageDetail(String)
+ * @see #setMessageDetailNotInRange(String)
*/
public String getMessageDetailNotInRange()
{
@@ -285,7 +285,7 @@
/**
* <p>Return custom hint notInRange message.</p>
* @return Custom hint message.
- * @see #setHintNotInRangeString)
+ * @see #setHintNotInRange
*/
public String getHintNotInRange()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LengthValidator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LengthValidator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LengthValidator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LengthValidator.java Tue May 1 17:12:41 2007
@@ -173,7 +173,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where input value exceeds the <code>maximum</code> value set.</p>
* @return Custom error message.
- * @see #setMaximumMessageDetail(String)
+ * @see #setMessageDetailMaximum(String)
*/
public String getMessageDetailMaximum()
{
@@ -197,7 +197,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where, input value is less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setMinimumMessageDetail(String)
+ * @see #setMessageDetailMinimum(String)
*/
public String getMessageDetailMinimum()
{
@@ -222,7 +222,7 @@
* for cases where, input value exceeds the <code>maximum</code> value and is
* less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setNotInRangeMessageDetail(String)
+ * @see #setMessageDetailNotInRange(String)
*/
public String getMessageDetailNotInRange()
{
@@ -285,7 +285,7 @@
/**
* <p>Return custom hint notInRange message.</p>
* @return Custom hint message.
- * @see #setHintNotInRangeString)
+ * @see #setHintNotInRange
*/
public String getHintNotInRange()
{
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LongRangeValidator.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LongRangeValidator.java?view=diff&rev=534284&r1=534283&r2=534284
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LongRangeValidator.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/src/main/java/org/apache/myfaces/trinidad/validator/LongRangeValidator.java Tue May 1 17:12:41 2007
@@ -175,7 +175,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where input value exceeds the <code>maximum</code> value set.</p>
* @return Custom error message.
- * @see #setMaximumMessageDetail(String)
+ * @see #setMessageDetailMaximum(String)
*/
public String getMessageDetailMaximum()
{
@@ -199,7 +199,7 @@
* <p>Return custom detail error message that was set for creating {@link FacesMessage},
* for cases where, input value is less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setMinimumMessageDetail(String)
+ * @see #setMessageDetailMinimum(String)
*/
public String getMessageDetailMinimum()
{
@@ -224,7 +224,7 @@
* for cases where, input value exceeds the <code>maximum</code> value and is
* less than the <code>minimum</code> value set.</p>
* @return Custom error message.
- * @see #setNotInRangeMessageDetail(String)
+ * @see #setMessageDetailNotInRange(String)
*/
public String getMessageDetailNotInRange()
{
@@ -287,7 +287,7 @@
/**
* <p>Return custom hint notInRange message.</p>
* @return Custom hint message.
- * @see #setHintNotInRangeString)
+ * @see #setHintNotInRange
*/
public String getHintNotInRange()
{