[jira] Resolved: (HAMA-305) Redundant use of synchronize keyword

["Edward J. Yoon (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HAMA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon resolved HAMA-305.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.2.0
         Assignee: Filipe Manana

Patch looks great. +1
I've just committed this. Thanks!

> Redundant use of synchronize keyword
> ------------------------------------
>
>                 Key: HAMA-305
>                 URL: https://issues.apache.org/jira/browse/HAMA-305
>             Project: Hama
>          Issue Type: Bug
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 0.2.0
>
>         Attachments: hama-305.patch
>
>
> In GroomServer.startNewTask(), we synchronize on the newly created TaskInProgress. This is unnecessary since it's a method local variable. I believe the intention was to synchronize on 'this' or on the collection runningTasks.
> Also, when the task is launched, I believe it doesn't need to be inside the synchronized block. The only field it accesses from the parent class is the configuration (conf).
> Patch attached.
> cheers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.