You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/05 16:49:00 UTC
[jira] [Commented] (NIFI-5237) Wrong redirect from login behind a
context path, when using OpenID authentication
[ https://issues.apache.org/jira/browse/NIFI-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502091#comment-16502091 ]
ASF GitHub Bot commented on NIFI-5237:
--------------------------------------
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2763
NIFI-5237: Considering proxy headers follow OIDC login
NIFI-5237:
- Ensuring the proxy headers are considered when redirecting the user following a OIDC or Knox login exchange.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-5237
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2763
----
commit bb8ab4f4b411e56eae98eb180026b83ada7ac35f
Author: Matt Gilman <ma...@...>
Date: 2018-06-05T16:47:36Z
NIFI-5237:
- Ensuring the proxy headers are considered when redirecting the user following a OIDC or Knox login exchange.
----
> Wrong redirect from login behind a context path, when using OpenID authentication
> ---------------------------------------------------------------------------------
>
> Key: NIFI-5237
> URL: https://issues.apache.org/jira/browse/NIFI-5237
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.6.0
> Environment: NiFi behind a reverse proxy (HAProxy)
> Reporter: Damian Czaja
> Priority: Major
>
> When I deploy NiFi behind a custom context path eg ([https://my-nifi/my/context/path/)|https://nifi/my/context/path/)] and using OpenID authentication, after the login I'm redirected to [https://my-nifi/nifi/|https://my-nifi/nifi] instead of [https://my-nifi/my/context/path/nifi/] .
> My presumption is, that the relative redirect in httpServletResponse.sendRedirect it's respecting the contextPath provided in the X-ProxyContextPath header:
> [https://github.com/apache/nifi/blob/rel/nifi-1.6.0/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java#L269]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)