You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Villu Ruusmann (JIRA)" <ji...@apache.org> on 2010/02/23 22:33:27 UTC
[jira] Created: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Fallback mechanism for broken CFF fonts
---------------------------------------
Key: PDFBOX-635
URL: https://issues.apache.org/jira/browse/PDFBOX-635
Project: PDFBox
Issue Type: Improvement
Components: PDModel
Affects Versions: 1.0.1
Reporter: Villu Ruusmann
Attachments: PDFBox.patch
PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837602#action_12837602 ]
Daniel Wilson commented on PDFBOX-635:
--------------------------------------
Villu,
I entirely agree with the *concept* of this patch -- if the right means of parsing fails, warn and fall back to something less correct that will work.
Reading your patch, I see the warning. But I don't see the fallback actually occurring.
Does it indeed fall back to a Type1 font? Could you explain how the code is doing this?
Thanks!
Daniel
> Fallback mechanism for broken CFF fonts
> ---------------------------------------
>
> Key: PDFBOX-635
> URL: https://issues.apache.org/jira/browse/PDFBOX-635
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.0.1
> Reporter: Villu Ruusmann
> Attachments: PDFBox.patch
>
>
> PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
> PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Posted by "Villu Ruusmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Villu Ruusmann updated PDFBOX-635:
----------------------------------
Attachment: PDFBox.patch
> Fallback mechanism for broken CFF fonts
> ---------------------------------------
>
> Key: PDFBOX-635
> URL: https://issues.apache.org/jira/browse/PDFBOX-635
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.0.1
> Reporter: Villu Ruusmann
> Attachments: PDFBox.patch
>
>
> PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
> PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated PDFBOX-635:
---------------------------------
Fix Version/s: 1.1.0
> Fallback mechanism for broken CFF fonts
> ---------------------------------------
>
> Key: PDFBOX-635
> URL: https://issues.apache.org/jira/browse/PDFBOX-635
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.0.0
> Reporter: Villu Ruusmann
> Fix For: 1.1.0
>
> Attachments: PDFBox.patch
>
>
> PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
> PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837853#action_12837853 ]
Daniel Wilson commented on PDFBOX-635:
--------------------------------------
Using the file linked in PDFBOX-634 , your patch markedly reduces the errors logged.
I'll incorporate it. Thanks!
> Fallback mechanism for broken CFF fonts
> ---------------------------------------
>
> Key: PDFBOX-635
> URL: https://issues.apache.org/jira/browse/PDFBOX-635
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.0.1
> Reporter: Villu Ruusmann
> Attachments: PDFBox.patch
>
>
> PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
> PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Posted by "Villu Ruusmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837756#action_12837756 ]
Villu Ruusmann commented on PDFBOX-635:
---------------------------------------
This patch can only be understood if one analyzes it in the context of method org.apache.pdfbox.pdmodel.font.PDFontFactory#createFont(COSDictionary).
Here's an excerpt:
if(cosDictionary.getFontType().equals("Type1")){
PDFont retvalue = new Type1Font(cosDictionary);
if(cosDictionary.getFontSubType().equals("Type1C")){
try {
retvalue = new Type1CFont(cosDictionary);
} catch(Exception e){
log.warn("Cannot create replacement Type1C font, returning original Type1 font");
}
}
return retvalue;
}
> Fallback mechanism for broken CFF fonts
> ---------------------------------------
>
> Key: PDFBOX-635
> URL: https://issues.apache.org/jira/browse/PDFBOX-635
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.0.1
> Reporter: Villu Ruusmann
> Attachments: PDFBox.patch
>
>
> PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
> PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PDFBOX-635) Fallback mechanism for broken CFF
fonts
Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Wilson resolved PDFBOX-635.
----------------------------------
Resolution: Fixed
Incorporated patch in revision 915854
> Fallback mechanism for broken CFF fonts
> ---------------------------------------
>
> Key: PDFBOX-635
> URL: https://issues.apache.org/jira/browse/PDFBOX-635
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.0.1
> Reporter: Villu Ruusmann
> Attachments: PDFBox.patch
>
>
> PDFBOX-542 has not proven to be sufficiently foolproof for real-world PDF documents.
> PDFBox should fallback to a Type1 font with appropriate warning message (this is the default behaviour with PDFBox 0.8.0 and earlier versions) when there is a problem parsing/interpreting a CFF (aka Type1C) font.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.