You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/03 02:51:00 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

AngersZhuuuu commented on a change in pull request #34308:
URL: https://github.com/apache/spark/pull/34308#discussion_r741585626



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -593,6 +593,16 @@ object QueryExecutionErrors {
     new QueryExecutionException(message, e)
   }
 
+  def unsupportedParquetDictionaryDecodingError(
+      valueType: String,
+      dictionary: String,

Review comment:
       > Just let it take the dictionary object here? you can avoid having callers all call .getClass().getSimpleName()
   
   Hive tried this, but QueryExecutionError is under catalyst module, spark didn't add dependency of parquet in this module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org