You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:34:47 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3157: NO-JIRA Add RetryRule to FailoverClusterTest
brusdev opened a new pull request #3157:
URL: https://github.com/apache/activemq-artemis/pull/3157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3157: NO-JIRA Add RetryRule to FailoverClusterTest
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3157:
URL: https://github.com/apache/activemq-artemis/pull/3157#discussion_r433429792
##########
File path: tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverClusterTest.java
##########
@@ -34,14 +34,19 @@
import org.apache.activemq.artemis.core.config.Configuration;
import org.apache.activemq.artemis.jms.server.config.impl.JMSConfigurationImpl;
import org.apache.activemq.artemis.jms.server.embedded.EmbeddedJMS;
+import org.apache.activemq.artemis.utils.RetryRule;
import org.apache.activemq.broker.artemiswrapper.OpenwireArtemisBaseTest;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
+import org.junit.Rule;
import org.junit.Test;
public class FailoverClusterTest extends OpenwireArtemisBaseTest {
+ @Rule
+ public RetryRule retryRule = new RetryRule(1);
Review comment:
I would make it 3 on this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3157: NO-JIRA Add RetryRule to FailoverClusterTest
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3157:
URL: https://github.com/apache/activemq-artemis/pull/3157#issuecomment-637054293
I changed it to 2 as I merged it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3157: NO-JIRA Add RetryRule to FailoverClusterTest
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3157:
URL: https://github.com/apache/activemq-artemis/pull/3157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org