[jira] [Comment Edited] (MESOS-4621) --disable-optimize triggers optimized builds.

["Yong Tang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197471#comment-15197471 ] 

Yong Tang edited comment on MESOS-4621 at 3/16/16 3:12 PM:
-----------------------------------------------------------

Added a review request:
https://reviews.apache.org/r/44911/

The issue was that, in original configure.ac, 
{code}
AC_ARG_ENABLE([optimize],
              AS_HELP_STRING(...),
              [enable_optimize=yes], [])
{code}

The third field is "action-if-present", it could be
# --enable-optimize
# --enable-optimize=yes
# --enable-optimize=no
# --disable-optimize 

Yet in the original code it always set "[enable_optimize=yes]".

This could be fixed by simply replacing "[enable_optimize=yes]" with "[]" as by default AC_ARG_ENABLE will always set the value of "enable_optimize" correctly anyway:

# --enable-optimize : [enable_optimize=yes]
# --enable-optimize=yes : [enable_optimize=yes]
# --enable-optimize=no : [enable_optimize=no]
# --disable-optimize : [enable_optimize=no]


was (Author: yongtang):
Added a review request:
https://reviews.apache.org/r/44911/

The issue was that, in original configure.ac, 
{code}
AC_ARG_ENABLE([optimize],
              AS_HELP_STRING(...),
              [enable_optimize=yes], [])
{code}

The third field is "action-if-present", it could be
# --enable-optimize
# --enable-optimize=yes
# --enable-optimize=no
# --disable-optimize 

Yet in the original code it always set "[enable_optimize=yes]".

This could be fixed by simply replace "[enable_optimize=yes]" with "[]" as by default AC_ARG_ENABLE will always set the value of "enable_optimize" correctly anyway:

# --enable-optimize : [enable_optimize=yes]
# --enable-optimize=yes : [enable_optimize=yes]
# --enable-optimize=no : [enable_optimize=no]
# --disable-optimize : [enable_optimize=no]

> --disable-optimize triggers optimized builds.
> ---------------------------------------------
>
>                 Key: MESOS-4621
>                 URL: https://issues.apache.org/jira/browse/MESOS-4621
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Till Toenshoff
>            Assignee: Yong Tang
>            Priority: Minor
>
> The toggle-logic of the build configuration argument {{optimize}} appears to be implemented incorrectly. When using the perfectly legal invocation;
> {noformat}
> ../configure --disable-optimize
> {noformat}
> What you get here is enabled optimizing {{O2}}.
> {noformat}
> ccache g++ -Qunused-arguments -fcolor-diagnostics -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBDL=1 -I. -I../../../../3rdparty/libprocess/3rdparty  -I../../../../3rdparty/libprocess/3rdparty/stout/include -Iprotobuf-2.5.0/src  -Igmock-1.7.0/gtest/include -Igmock-1.7.0/include -isystem boost-1.53.0 -Ipicojson-1.3.0 -DPICOJSON_USE_INT64 -D__STDC_FORMAT_MACROS -Iglog-0.3.3/src -I/usr/local/opt/openssl/include -I/usr/local/opt/libevent/include -I/usr/local/opt/subversion/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0   -O2 -Wno-unused-local-typedef -std=c++11 -stdlib=libc++ -DGTEST_USE_OWN_TR1_TUPLE=1 -DGTEST_LANG_CXX11 -MT stout_tests-flags_tests.o -MD -MP -MF .deps/stout_tests-flags_tests.Tpo -c -o stout_tests-flags_tests.o `test -f 'stout/tests/flags_tests.cpp' || echo '../../../../3rdparty/libprocess/3rdparty/'`stout/tests/flags_tests.cpp
> {noformat}
> It seems more straightforward to actually disable optimizing for the above argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)