You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/05 12:19:58 UTC
Re: Review Request 55068: Added Capabilities to Framework struct of
Hierarchical allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55068/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 8:19 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
Changes
-------
rebase
Repository: mesos
Description
-------
Individual capabilities are collected into this struct and used in
allocator. This is step toward multi-role support of allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp a6424d624864155e1c87a28a63b784512c5c8722
src/master/allocator/mesos/hierarchical.cpp 91b1ec43940a788459f045ca4a4b82d4e8373bca
Diff: https://reviews.apache.org/r/55068/diff/
Testing
-------
make check on Ubuntu 14.04
Thanks,
Jay Guo
Re: Review Request 55068: Added Capabilities to Framework struct of
Hierarchical allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55068/#review161607
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 5, 2017, 12:19 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55068/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 12:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Individual capabilities are collected into this struct and used in
> allocator. This is step toward multi-role support of allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp a6424d624864155e1c87a28a63b784512c5c8722
> src/master/allocator/mesos/hierarchical.cpp 91b1ec43940a788459f045ca4a4b82d4e8373bca
>
> Diff: https://reviews.apache.org/r/55068/diff/
>
>
> Testing
> -------
>
> make check on Ubuntu 14.04
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 55068: Added Capabilities to Framework struct of
Hierarchical allocator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55068/#review160666
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55021, 55066, 55068]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 5, 2017, 12:19 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55068/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 12:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Individual capabilities are collected into this struct and used in
> allocator. This is step toward multi-role support of allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp a6424d624864155e1c87a28a63b784512c5c8722
> src/master/allocator/mesos/hierarchical.cpp 91b1ec43940a788459f045ca4a4b82d4e8373bca
>
> Diff: https://reviews.apache.org/r/55068/diff/
>
>
> Testing
> -------
>
> make check on Ubuntu 14.04
>
>
> Thanks,
>
> Jay Guo
>
>