You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/22 20:03:09 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1643: Add `DataFusionError` -> `ArrowError` conversion

houqp commented on a change in pull request #1643:
URL: https://github.com/apache/arrow-datafusion/pull/1643#discussion_r790179772



##########
File path: datafusion/src/error.rs
##########
@@ -74,6 +74,8 @@ pub enum DataFusionError {
 
 impl DataFusionError {
     /// Wraps this [DataFusionError] as an [arrow::error::ArrowError].
+    ///
+    /// TODO this can be removed in favor if the conversion below

Review comment:
       ```suggestion
       /// TODO this can be removed in favor of the conversion below
   ```
   
   Why not remove this now? If we want to keep it, then it would be better to add a `deprecated` attribute.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org