You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "khanimteyaz (GitHub)" <gi...@apache.org> on 2018/12/31 13:39:00 UTC

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3106: Should org.apache.dubbo.registry.support.AbstractRegistry#getRegistered returns unmodifiable sets?

@kezhenxu94 , what you mentioned I am with it. I think we should keep the responsibility of operation on objects e.g. in this case clearing the registry to the owner of registries object AbstractRegistry.java and when ever it returns any mutable member variable it should return copy of it. But having said that we also needs to consider memory footprint/performance of creating clone copy of returned object. I beleve it should not change memory footprint or performance drastically but better to have some data around it.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3106 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org