You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2020/06/11 06:56:09 UTC

[GitHub] [nutch] pmezard commented on pull request #533: NUTCH-2791 Handle GCS URLs in stats commands

pmezard commented on pull request #533:
URL: https://github.com/apache/nutch/pull/533#issuecomment-642450747


   Fixed and rebased, PTAL.
   
   Two questions:
   - When you request changes, do you want them squashed immediately in the new code or do you prefer independant commit. As a reviewer I prefer independant commits to avoir having to re-read everything but the README suggests you prefer to squash everything.
   - What is the correct way to test such a change to nutch script help? I ran `ant zip-bin` and redeployed the code locally but maybe there is something faster, working directly in-tree?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org