You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "eaugene (via GitHub)" <gi...@apache.org> on 2023/06/02 05:38:48 UTC
[GitHub] [pinot] eaugene opened a new issue, #10832: option(SkipUpsert=true) is not case inSensitive
eaugene opened a new issue, #10832:
URL: https://github.com/apache/pinot/issues/10832
Using `option(SkipUpsert=true)` in Query works by including upserted records, while `option(skipUpsert=true)` doesn't work as intended, also is silent and doesn't throw any error when processing query.
Pinot Version:0.11
label: `bug`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10832: option(skipUpsert=true) is not case inSensitive
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10832:
URL: https://github.com/apache/pinot/issues/10832#issuecomment-1574383820
All query options are case sensitive now, and pinot doesn't throw error when it cannot recognize an option. One solution would be to canonicalize the option keys, and check if the key is within an allowed key list. The problem with this approach is that it makes it hard to extend the option keys because user might want to put some options not understood by pinot, but used in their custom code plugged in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10832: option(skipUpsert=true) is not case inSensitive
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10832:
URL: https://github.com/apache/pinot/issues/10832#issuecomment-1579318320
Yes, I think it is a fair ask. What we can do is to always use lower case to store and look up query options. Do you want to raise a PR to add this support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] eaugene commented on issue #10832: option(skipUpsert=true) is not case inSensitive
Posted by "eaugene (via GitHub)" <gi...@apache.org>.
eaugene commented on issue #10832:
URL: https://github.com/apache/pinot/issues/10832#issuecomment-1579904691
Sure @Jackie-Jiang . Please assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] eaugene commented on issue #10832: option(skipUpsert=true) is not case inSensitive
Posted by "eaugene (via GitHub)" <gi...@apache.org>.
eaugene commented on issue #10832:
URL: https://github.com/apache/pinot/issues/10832#issuecomment-1576092842
Got it @Jackie-Jiang . But on the flip side , can we make query options case insensitive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org