You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jan Høydahl (JIRA)" <ji...@apache.org> on 2011/02/15 13:23:57 UTC
[jira] Created: (SOLR-2363) Rename the "dismax" request handler
Rename the "dismax" request handler
-----------------------------------
Key: SOLR-2363
URL: https://issues.apache.org/jira/browse/SOLR-2363
Project: Solr
Issue Type: Bug
Components: Schema and Analysis
Reporter: Jan Høydahl
It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] Created: (SOLR-2363) Rename the "dismax" request handler
Posted by Erick Erickson <er...@gmail.com>.
+1
2011/2/15 Jan Høydahl (JIRA) <ji...@apache.org>:
> Rename the "dismax" request handler
> -----------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
>
> --
> This message is automatically generated by JIRA.
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2363) Rename the example "dismax" request
handler instance
Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994837#comment-12994837 ]
Jan Høydahl commented on SOLR-2363:
-----------------------------------
Also we must remember that it's only (supposed to be) an EXAMPLE schema. It's where most people start learning about Solr, request handlers and the like - thus it should not be confusing, but rather have super-clear comments helping the user get going.
Also, per definition, changing this in the example schema will not break anything anywhere :)
&qt=robust or &qt=userfriendly or &qt=onesearchbox could be other alternatives?
> Rename the example "dismax" request handler instance
> ----------------------------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Reopened: (SOLR-2363) Rename the "dismax" request handler
Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Høydahl reopened SOLR-2363:
-------------------------------
Reopening. This issue is not talking about the old DisMaxRequestHandler but the example SearchHandler config named "dismax".
We should probably start using the name "RequestHandler instance" or similar for these entries.
> Rename the "dismax" request handler
> -----------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2363) Rename the example "dismax" request
handler instance
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994817#comment-12994817 ]
Erick Erickson commented on SOLR-2363:
--------------------------------------
bq: Though i'm not convinced it really needs changing – we would also need to update all the documentation that refers to ?qt=dismax
I agree with Jan on this one. I distinctly remember having this confusion, and I've seen it go round multiple times on the user's list. Interestingly, I can't find anything on the Wiki where "qt=dismax" is in the text..
bq: I would suggest we have a qt=dismax that is plain vanilla,
Please no! The whole point is to avoid the confusion over qt=dismax and defType=dismax.
> Rename the example "dismax" request handler instance
> ----------------------------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2363) Rename the "dismax" request handler
Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Høydahl updated SOLR-2363:
------------------------------
Attachment: SOLR-2363.patch
This patch renames the example requesthandler to "dismaxexample", updates the outdated comment with more proper reference to DisMaxQParser and switches to edismax as default.
> Rename the "dismax" request handler
> -----------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] Commented: (SOLR-2363) Rename the example "dismax" request
handler instance
Posted by Bill Bell <be...@comcast.net>.
Since the qt=dismax has specific qt fields, I would suggest we have a
qt=dismax that is plain vanilla, and one that is called qt=dismaxexample
with the fields.
On 2/15/11 7:01 AM, "Ryan McKinley (JIRA)" <ji...@apache.org> wrote:
>
> [
>https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.pl
>ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994793#comm
>ent-12994793 ]
>
>Ryan McKinley commented on SOLR-2363:
>-------------------------------------
>
>ah - my bad.
>
>what about something more descriptive? dismax is kinda cryptic. maybe
>'escaped', 'safe', or just 'query'
>
>Though i'm not convinced it really needs changing -- we would also need
>to update all the documentation that refers to ?qt=dismax
>
>> Rename the example "dismax" request handler instance
>> ----------------------------------------------------
>>
>> Key: SOLR-2363
>> URL: https://issues.apache.org/jira/browse/SOLR-2363
>> Project: Solr
>> Issue Type: Bug
>> Components: Schema and Analysis
>> Reporter: Jan Høydahl
>> Labels: dismax, example-schema
>> Attachments: SOLR-2363.patch
>>
>>
>> It is misleading that one of the requestHandlers in the example schema
>>is named the same as the queryParser "dismax". It creates confusion as
>>to whether the use of defType=dismax vs qt=dismax. It would be better if
>>the example requestHandler was named e.g. "dismaxexample"
>
>--
>This message is automatically generated by JIRA.
>-
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2363) Rename the example "dismax" request
handler instance
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994793#comment-12994793 ]
Ryan McKinley commented on SOLR-2363:
-------------------------------------
ah - my bad.
what about something more descriptive? dismax is kinda cryptic. maybe 'escaped', 'safe', or just 'query'
Though i'm not convinced it really needs changing -- we would also need to update all the documentation that refers to ?qt=dismax
> Rename the example "dismax" request handler instance
> ----------------------------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2363) Rename the "dismax" request handler
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-2363.
---------------------------------
Resolution: Duplicate
The DismaxRequestHandler and StandardRequestHandler are both deprecated and replaced with SearchHandler.
> Rename the "dismax" request handler
> -----------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2363) Rename the example "dismax" request
handler instance
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-2363.
----------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.1
dealt with in SOLR-2397, no longer have a handler named "dismax"
> Rename the example "dismax" request handler instance
> ----------------------------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2363) Rename the example "dismax" request
handler instance
Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Høydahl updated SOLR-2363:
------------------------------
Summary: Rename the example "dismax" request handler instance (was: Rename the "dismax" request handler)
Just renaming issue to reflect that it's about a requesthandler instance
> Rename the example "dismax" request handler instance
> ----------------------------------------------------
>
> Key: SOLR-2363
> URL: https://issues.apache.org/jira/browse/SOLR-2363
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Labels: dismax, example-schema
> Attachments: SOLR-2363.patch
>
>
> It is misleading that one of the requestHandlers in the example schema is named the same as the queryParser "dismax". It creates confusion as to whether the use of defType=dismax vs qt=dismax. It would be better if the example requestHandler was named e.g. "dismaxexample"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org