You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2011/06/04 09:33:47 UTC
[jira] [Created] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Ensure HiveConf includes all properties defined in hive-default.xml
-------------------------------------------------------------------
Key: HIVE-2196
URL: https://issues.apache.org/jira/browse/HIVE-2196
Project: Hive
Issue Type: Bug
Components: Configuration
Reporter: Carl Steinbach
Assignee: Carl Steinbach
There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2196:
-----------------------------
Status: Open (was: Patch Available)
For each one of these, we need to verify that the parameter is actually used. For example, I searched the code for references to hive.optimize.pruner, and could not find any. In such cases, we should delete from xml rather than add to HiveConf.
For cases where the parameter is still used (e.g. hive.io.exception.handlers), we should change the points of reference to go through the HiveConf symbol.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2196:
---------------------------------
Status: Open (was: Patch Available)
I get a compilation error in HiveIOExceptionHandlerChain. Looks like you need to import HiveConf.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085758#comment-13085758 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
These configurations are added to HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087484#comment-13087484 ]
Carl Steinbach commented on HIVE-2196:
--------------------------------------
+1. Will commit if tests pass.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.4.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146110#comment-13146110 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-11-08 07:07:28.602261)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
refreshed the patch
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1198626
trunk/conf/hive-default.xml 1198626
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1198626
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.6.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081630#comment-13081630 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
Patch updated with below information
*The below configurations are not used in the code base so removed from the hive-default.xml*
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
*The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java*
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2196:
---------------------------------
Status: Open (was: Patch Available)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2196:
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.6.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081850#comment-13081850 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
Review request for hive, Carl Steinbach and John Sichi.
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275
trunk/conf/hive-default.xml 1155275
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.2.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2196:
---------------------------------
Attachment: HIVE-2196.build.log
@Chinna: Compilation still fails for me. Please see the attached ant build log for more details.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach reassigned HIVE-2196:
------------------------------------
Assignee: Chinna Rao Lalam (was: Carl Steinbach)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.6.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.6.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150187#comment-13150187 ]
Hudson commented on HIVE-2196:
------------------------------
Integrated in Hive-trunk-h0.21 #1085 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1085/])
HIVE-2196 Ensure HiveConf includes all properties defined in
hive-default.xml (Chinna Rao Lalam via namit)
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201872
Files :
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/conf/hive-default.xml
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.6.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.6.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Open (was: Patch Available)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095695#comment-13095695 ]
Carl Steinbach commented on HIVE-2196:
--------------------------------------
@Chinna: Please followup on the issue raised by Ashutosh. Configuration property values should match in HiveConf and hive-default.xml. If they don't match then the value that appears in hive-default.xml should be copied over to HiveConf. Thanks.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081851#comment-13081851 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
Added review board request.
https://reviews.apache.org/r/1423/
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087766#comment-13087766 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
Hi Carl,
i applied the patch on trunk i did not get compilation failure and in HiveIOExceptionHandlerChain HiveConf is improted in this patch. Can u check one more time. I am submitting the same patch.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Affects Version/s: 0.8.0
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125620#comment-13125620 ]
Ashutosh Chauhan commented on HIVE-2196:
----------------------------------------
@Chinna,
I guess you need to mark it as Patch Available so that committers know that its ready for review. We should get this in, lest some other property get introduced which again violates this.
Others,
HiveConf first loads hive-default.xml and then loads hive-site.xml Isn't loading hive-default.xml will be redundant after this change. Default values should come from HiveConf not from external xml file, if user wishes to override he should provide that value in hive-site.xml. We should stop loading hive-default.xml while initializing HiveConf.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115583#comment-13115583 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-09-27 15:51:37.029125)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
All tests passed
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1175859
trunk/conf/hive-default.xml 1175859
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1175859
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1175859
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1175859
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127692#comment-13127692 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-10-14 16:54:00.383612)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
Rebase the patch on the trunk
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182263
trunk/conf/hive-default.xml 1182263
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182263
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1182263
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1182263
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.5.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097758#comment-13097758 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-09-06 06:16:26.733090)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
Reworked on the patch and latest patch taken care the below issues
1) Configuration property values verified and made it sync with the hive-default.xml
2) Compilation failure corrected.
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1165244
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1165244
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1165244
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1165244
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1165244
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1165244
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1165244
trunk/conf/hive-default.xml 1165244
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1165244
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097757#comment-13097757 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
@Carl: Reworked on the patch and latest patch taken care the below issues
1) Configuration property values verified and made it sync with the hive-default.xml
2) Compilation failure corrected.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085757#comment-13085757 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-08-16 14:51:32.766435)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
These configurations are added to HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1158213
trunk/conf/hive-default.xml 1158213
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1158213
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1158213
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1158213
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1158213
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2196:
---------------------------------
Status: Open (was: Patch Available)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.1.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.3.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127691#comment-13127691 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
Rebase the patch on the trunk
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145219#comment-13145219 ]
Namit Jain commented on HIVE-2196:
----------------------------------
@Chinna, this slipped through the cracks and is not generating a lot of merge conflicts.
I think this is a really good idea - Can you refresh ? I will definitely go over it this time and try to get it in.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Attachment: HIVE-2196.patch
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2196:
-----------------------------
Status: Open (was: Patch Available)
And, also please mark it as 'Patch Available' so that everyone takes a look
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.5.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2196:
---------------------------------
Status: Open (was: Patch Available)
Please run the tests before submitting a patch. All of the tests currently fail due to an assertion error in HiveConf:
{noformat}
java.lang.AssertionError
at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:638)
at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:648)
at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.getQuorumServers(ZooKeeperHiveLockManager.java:80)
at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.setContext(ZooKeeperHiveLockManager.java:92)
at org.apache.hadoop.hive.ql.Driver.setLockManager(Driver.java:168)
at org.apache.hadoop.hive.ql.Driver.checkLockManager(Driver.java:141)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:908)
at org.apache.hadoop.hive.ql.QTestUtil.runLoadCmd(QTestUtil.java:394)
at org.apache.hadoop.hive.ql.QTestUtil.createSources(QTestUtil.java:441)
at org.apache.hadoop.hive.cli.TestCliDriver.<clinit>(TestCliDriver.java:38)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:169)
at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:337)
at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
{noformat}
Also, please update the contents of data/conf/hive-site.xml
Thanks.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2196:
-----------------------------------
Status: Patch Available (was: Open)
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093319#comment-13093319 ]
Carl Steinbach commented on HIVE-2196:
--------------------------------------
@Chinna: I suspect this is working for you because you haven't run 'ant clean'. If you
do you'll see that your changes have introduced a circular build dependency: hive-shims
depends on hive-common and vice-versa, whereas previously hive-common only depended
on hive-shims. If you revert your changes to the shims/ directory I think this patch
will build cleanly and should be ready to commit.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Chinna Rao Lalam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115597#comment-13115597 ]
Chinna Rao Lalam commented on HIVE-2196:
----------------------------------------
All tests passed. Changes make it sink the contents of hive-default.xml to Hiveconf.java. After hive-default.xml loaded hive-site.xml will load so no need to change the contents of hive-site.xml
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 0.8.0
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094304#comment-13094304 ]
Ashutosh Chauhan commented on HIVE-2196:
----------------------------------------
What about the values? Some keys have different default value in HiveConf then from hive-default.xml. Shouldn't the values should also match up in two places?
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.build.log, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2196) Ensure HiveConf includes all
properties defined in hive-default.xml
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084944#comment-13084944 ]
jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/#review1451
-----------------------------------------------------------
bq. > The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
Actually, everything that appears in hive-default.xml should also appear in HiveConf and vice-versa.
- Carl
On 2011-08-09 19:11:13, chinna wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1423/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-09 19:11:13)
bq.
bq.
bq. Review request for hive, Carl Steinbach and John Sichi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The below configurations are not used in the code base so removed from the hive-default.xml
bq.
bq. hive.mapjoin.hashtable.initialCapacity
bq. hive.mapjoin.hashtable.loadfactor
bq. hive.mapjoin.smalltable.filesize
bq. hive.optimize.pruner
bq. hive.stats.jdbc.atomic
bq. hive.concurrency.manager
bq.
bq. The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
bq.
bq. javax.jdo.option.ConnectionDriverName
bq. javax.jdo.PersistenceManagerFactoryClass
bq. javax.jdo.option.DetachAllOnCommit
bq. javax.jdo.option.NonTransactionalRead
bq. javax.jdo.option.ConnectionUserName
bq. fs.har.impl
bq.
bq.
bq. This addresses bug HIVE-2196.
bq. https://issues.apache.org/jira/browse/HIVE-2196
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275
bq. trunk/conf/hive-default.xml 1155275
bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275
bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275
bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275
bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275
bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275
bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275
bq. trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275
bq.
bq. Diff: https://reviews.apache.org/r/1423/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed
bq.
bq.
bq. Thanks,
bq.
bq. chinna
bq.
bq.
> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira