You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/15 06:44:07 UTC

[GitHub] [hudi] Zouxxyy opened a new pull request, #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Zouxxyy opened a new pull request, #7468:
URL: https://github.com/apache/hudi/pull/7468

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1352630472

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e42cf58d7a37de5f724673c71ea350937709041a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1373302334

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131",
       "triggerID" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbd6e7916ba0093e67b28e2bb2d6877e38f33623",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cbd6e7916ba0093e67b28e2bb2d6877e38f33623",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4166f0761b7fc3d5905cd8d180df63706ed53a2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131) 
   * cbd6e7916ba0093e67b28e2bb2d6877e38f33623 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy commented on a diff in pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #7468:
URL: https://github.com/apache/hudi/pull/7468#discussion_r1057563934


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RowCustomColumnsSortPartitioner.java:
##########
@@ -44,8 +44,8 @@ public RowCustomColumnsSortPartitioner(String[] columnNames) {
   @Override
   public Dataset<Row> repartitionRecords(Dataset<Row> records, int outputSparkPartitions) {
     final String[] sortColumns = this.sortColumnNames;
-    return records.coalesce(outputSparkPartitions)
-        .sortWithinPartitions(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns);
+    return records.sort(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns)

Review Comment:
   Yes, it partitions using rangepartitioner, but unordered within a single partition. Unless repartitionByRange then sortWithinPartitions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy commented on a diff in pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #7468:
URL: https://github.com/apache/hudi/pull/7468#discussion_r1050721238


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RowCustomColumnsSortPartitioner.java:
##########
@@ -44,8 +44,8 @@ public RowCustomColumnsSortPartitioner(String[] columnNames) {
   @Override
   public Dataset<Row> repartitionRecords(Dataset<Row> records, int outputSparkPartitions) {
     final String[] sortColumns = this.sortColumnNames;
-    return records.coalesce(outputSparkPartitions)
-        .sortWithinPartitions(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns);
+    return records.sort(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns)

Review Comment:
   @boneanxs `repartitionByRange` will not trigger sort, is there an API doing both sort and repartition with df? Now, I just implement it like `GlobalSortPartitionerWithRows` does



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1373102964

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131",
       "triggerID" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e42cf58d7a37de5f724673c71ea350937709041a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754) 
   * c4166f0761b7fc3d5905cd8d180df63706ed53a2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1373193946

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131",
       "triggerID" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4166f0761b7fc3d5905cd8d180df63706ed53a2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1373315669

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131",
       "triggerID" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbd6e7916ba0093e67b28e2bb2d6877e38f33623",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14140",
       "triggerID" : "cbd6e7916ba0093e67b28e2bb2d6877e38f33623",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4166f0761b7fc3d5905cd8d180df63706ed53a2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131) 
   * cbd6e7916ba0093e67b28e2bb2d6877e38f33623 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14140) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron merged pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
YannByron merged PR #7468:
URL: https://github.com/apache/hudi/pull/7468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1352631288

   @boneanxs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1353226835

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e42cf58d7a37de5f724673c71ea350937709041a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1352682419

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e42cf58d7a37de5f724673c71ea350937709041a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs commented on a diff in pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
boneanxs commented on code in PR #7468:
URL: https://github.com/apache/hudi/pull/7468#discussion_r1057515876


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RowCustomColumnsSortPartitioner.java:
##########
@@ -44,8 +44,8 @@ public RowCustomColumnsSortPartitioner(String[] columnNames) {
   @Override
   public Dataset<Row> repartitionRecords(Dataset<Row> records, int outputSparkPartitions) {
     final String[] sortColumns = this.sortColumnNames;
-    return records.coalesce(outputSparkPartitions)
-        .sortWithinPartitions(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns);
+    return records.sort(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns)

Review Comment:
   I think `repartitionByRange` allows you to provide sort-order



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs commented on a diff in pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
boneanxs commented on code in PR #7468:
URL: https://github.com/apache/hudi/pull/7468#discussion_r1050483022


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RowCustomColumnsSortPartitioner.java:
##########
@@ -44,8 +44,8 @@ public RowCustomColumnsSortPartitioner(String[] columnNames) {
   @Override
   public Dataset<Row> repartitionRecords(Dataset<Row> records, int outputSparkPartitions) {
     final String[] sortColumns = this.sortColumnNames;
-    return records.coalesce(outputSparkPartitions)
-        .sortWithinPartitions(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns);
+    return records.sort(HoodieRecord.PARTITION_PATH_METADATA_FIELD, sortColumns)

Review Comment:
   Good catch, here maybe we can use `repartitionByRange` to gain the same behavior with the `RDDCustomColumnsSortPartitioner`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1373100427

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e42cf58d7a37de5f724673c71ea350937709041a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754) 
   * c4166f0761b7fc3d5905cd8d180df63706ed53a2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1373750636

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13754",
       "triggerID" : "e42cf58d7a37de5f724673c71ea350937709041a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14131",
       "triggerID" : "c4166f0761b7fc3d5905cd8d180df63706ed53a2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbd6e7916ba0093e67b28e2bb2d6877e38f33623",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14140",
       "triggerID" : "cbd6e7916ba0093e67b28e2bb2d6877e38f33623",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cbd6e7916ba0093e67b28e2bb2d6877e38f33623 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14140) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron commented on pull request #7468: [HUDI-5394] Fix RowCustomColumnsSortPartitioner

Posted by GitBox <gi...@apache.org>.
YannByron commented on PR #7468:
URL: https://github.com/apache/hudi/pull/7468#issuecomment-1375010583

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org