You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/06/03 14:06:06 UTC

[GitHub] [fineract] taskain7 commented on a diff in pull request #2344: Fineract with ReadOnly tenant database connection

taskain7 commented on code in PR #2344:
URL: https://github.com/apache/fineract/pull/2344#discussion_r888978305


##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0014_remove_unused_jobs.xml:
##########
@@ -21,6 +21,9 @@
 -->
 <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
     <changeSet author="fineract" id="1">
+        <sql>

Review Comment:
   nice catch @josehernandezfintecheandomx , I didn't find this issue when I made this change.
   IMHO we can keep this delete in this PR, just make sure that the migration can run for anybody (who already ran my changes and aalso who didn't)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org