You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/05 23:41:15 UTC

[GitHub] [superset] graceguo-supercat opened a new pull request #13955: fix: null exception from adhoc metric popover

graceguo-supercat opened a new pull request #13955:
URL: https://github.com/apache/superset/pull/13955


   ### SUMMARY
   This PR is to fix a JS exception, which is specific to druid dataset. When user tried to add/edit Metrics for a druid dataset, JS exception is thrown.
   
   
   ### TEST PLAN
   CI and manual test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie merged pull request #13955: fix: null exception from adhoc metric popover

Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #13955:
URL: https://github.com/apache/superset/pull/13955


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie closed pull request #13955: fix: null exception from adhoc metric popover

Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed pull request #13955:
URL: https://github.com/apache/superset/pull/13955


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13955: fix: null exception from adhoc metric popover

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13955:
URL: https://github.com/apache/superset/pull/13955#issuecomment-813722559


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=h1) Report
   > Merging [#13955](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=desc) (9a105f1) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.81%`.
   > The diff coverage is `92.59%`.
   
   > :exclamation: Current head 9a105f1 differs from pull request most recent head 2aa1b0b. Consider uploading reports for the commit 2aa1b0b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13955/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13955      +/-   ##
   ==========================================
   + Coverage   77.83%   78.64%   +0.81%     
   ==========================================
     Files         934      935       +1     
     Lines       47320    47375      +55     
     Branches     5913     5973      +60     
   ==========================================
   + Hits        36831    37260     +429     
   + Misses      10346     9972     -374     
     Partials      143      143              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <73.62%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
   | [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
   | [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <ø> (ø)` | |
   | [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
   | [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
   | [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `82.85% <ø> (ø)` | |
   | ... and [82 more](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=footer). Last update [73a2cc3...2aa1b0b](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13955: fix: null exception from adhoc metric popover

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13955:
URL: https://github.com/apache/superset/pull/13955#issuecomment-813722559


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=h1) Report
   > Merging [#13955](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=desc) (9a105f1) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.81%`.
   > The diff coverage is `92.59%`.
   
   > :exclamation: Current head 9a105f1 differs from pull request most recent head 2aa1b0b. Consider uploading reports for the commit 2aa1b0b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13955/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13955      +/-   ##
   ==========================================
   + Coverage   77.83%   78.64%   +0.81%     
   ==========================================
     Files         934      935       +1     
     Lines       47320    47375      +55     
     Branches     5913     5973      +60     
   ==========================================
   + Hits        36831    37260     +429     
   + Misses      10346     9972     -374     
     Partials      143      143              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <73.62%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
   | [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
   | [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <ø> (ø)` | |
   | [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
   | [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
   | [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `82.85% <ø> (ø)` | |
   | ... and [82 more](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=footer). Last update [73a2cc3...2aa1b0b](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13955: fix: null exception from adhoc metric popover

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13955:
URL: https://github.com/apache/superset/pull/13955#issuecomment-813722559


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=h1) Report
   > Merging [#13955](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=desc) (9a105f1) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.03%`.
   > The diff coverage is `92.59%`.
   
   > :exclamation: Current head 9a105f1 differs from pull request most recent head 2aa1b0b. Consider uploading reports for the commit 2aa1b0b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13955/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13955      +/-   ##
   ==========================================
   + Coverage   77.83%   77.87%   +0.03%     
   ==========================================
     Files         934      935       +1     
     Lines       47320    47375      +55     
     Branches     5913     5973      +60     
   ==========================================
   + Hits        36831    36892      +61     
   + Misses      10346    10323      -23     
   - Partials      143      160      +17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.82% <73.62%> (-5.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
   | [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
   | [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <ø> (ø)` | |
   | [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
   | [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
   | [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `80.00% <ø> (ø)` | |
   | ... and [130 more](https://codecov.io/gh/apache/superset/pull/13955/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=footer). Last update [73a2cc3...2aa1b0b](https://codecov.io/gh/apache/superset/pull/13955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org