[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #494: feat(dashboard): Allow dashboards to use external etcd with mtls

["tao12345666333 (via GitHub)" <gi...@apache.org>]

tao12345666333 commented on code in PR #494:
URL: https://github.com/apache/apisix-helm-chart/pull/494#discussion_r1264875152


##########
charts/apisix-dashboard/values.yaml:
##########
@@ -89,6 +89,16 @@ config:
       username: ~
       # -- Specifies etcd basic auth password if enable etcd auth
       password: ~
+
+      # -- Specifies a secret to be mounted on /etc/etcd for mtls usage
+      existingSecret: ""

Review Comment:
   I think this name is ambiguous. It would be better to add mtls to it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org