You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/04/02 22:19:12 UTC
[jira] Created: (THRIFT-423) -strict should turn omitted field ids
into compile error
-strict should turn omitted field ids into compile error
--------------------------------------------------------
Key: THRIFT-423
URL: https://issues.apache.org/jira/browse/THRIFT-423
Project: Thrift
Issue Type: New Feature
Reporter: Bryan Duxbury
Priority: Minor
Fix For: 0.2
I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-423) -strict should turn omitted field
ids into compile error
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695125#action_12695125 ]
David Reiss commented on THRIFT-423:
------------------------------------
I would be okay putting this in 0.1 (with -strict).
> -strict should turn omitted field ids into compile error
> --------------------------------------------------------
>
> Key: THRIFT-423
> URL: https://issues.apache.org/jira/browse/THRIFT-423
> Project: Thrift
> Issue Type: New Feature
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
>
> I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-423) -strict should turn omitted field ids
into compile error
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-423:
-------------------------------
Attachment: 0001-THRIFT-423.-Make-implicit-field-keys-an-error-with.patch
> -strict should turn omitted field ids into compile error
> --------------------------------------------------------
>
> Key: THRIFT-423
> URL: https://issues.apache.org/jira/browse/THRIFT-423
> Project: Thrift
> Issue Type: Improvement
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: 0001-THRIFT-423.-Make-implicit-field-keys-an-error-with.patch
>
>
> I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-423) -strict should turn omitted field ids
into compile error
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-423.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.2)
0.1
Assignee: David Reiss
Very crafty. Committed.
> -strict should turn omitted field ids into compile error
> --------------------------------------------------------
>
> Key: THRIFT-423
> URL: https://issues.apache.org/jira/browse/THRIFT-423
> Project: Thrift
> Issue Type: Improvement
> Reporter: Bryan Duxbury
> Assignee: David Reiss
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-423.-Make-implicit-field-keys-an-error-with.patch
>
>
> I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-423) -strict should turn omitted field ids
into compile error
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-423:
-------------------------------
Patch Info: [Patch Available]
> -strict should turn omitted field ids into compile error
> --------------------------------------------------------
>
> Key: THRIFT-423
> URL: https://issues.apache.org/jira/browse/THRIFT-423
> Project: Thrift
> Issue Type: Improvement
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: 0001-THRIFT-423.-Make-implicit-field-keys-an-error-with.patch
>
>
> I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-423) -strict should turn omitted field ids
into compile error
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-423:
-------------------------------
Issue Type: Improvement (was: New Feature)
Problem solved.
> -strict should turn omitted field ids into compile error
> --------------------------------------------------------
>
> Key: THRIFT-423
> URL: https://issues.apache.org/jira/browse/THRIFT-423
> Project: Thrift
> Issue Type: Improvement
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
>
> I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-423) -strict should turn omitted field
ids into compile error
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695126#action_12695126 ]
Bryan Duxbury commented on THRIFT-423:
--------------------------------------
However, it's a new feature, and we're in feature freeze at the moment. I say we wait.
> -strict should turn omitted field ids into compile error
> --------------------------------------------------------
>
> Key: THRIFT-423
> URL: https://issues.apache.org/jira/browse/THRIFT-423
> Project: Thrift
> Issue Type: New Feature
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
>
> I would love to be able to have the compiler outright fail if field ids aren't specified. I recognize this could break people's setup, so we should make it optional behavior, at least for the next release or so. It seems like it would make sense to just piggyback on the existing -strict option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.