You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/12 12:46:29 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new issue, #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
tisonkun opened a new issue, #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
See also https://github.com/apache/incubator-kvrocks/commit/341a989d75783d8dad76bbd5a4473dd345472337#r80998035.
cc @PragmaTwice @xiaobiaozhao
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240284925
I also found this issue on M1, but I'm wondering if we should make the LuaJIT as our default Lua VM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240877870
@PragmaTwice @git-hulk Thank you for your reply. Do you think we need to indicate in readme that MacOS needs to use the instructions @PragmaTwice provide?
Let me share my thoughts as a new user. When I encountered a compilation error on MacOS, I gave up using MacOS directly. The docker installation Ubuntu image is used instead. If there is a MacOS build version in readme, I think I can use it more happily.
```
$ git clone https://github.com/apache/incubator-kvrocks.git
$ cd incubator-kvrocks
$ ./x.py build # `./x.py build -h` to check more options;
# especially, `./x.py build --ghproxy` will fetch dependencies via ghproxy.com.
# macOS
./x.py build -DCMAKE_OSX_DEPLOYMENT_TARGET = Appropriate version
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240207708
Hi. I am using MacBook M1. According to https://github.com/apache/incubator-kvrocks/commit/341a989d75783d8dad76bbd5a4473dd345472337#r80998035, If I replace `${CMAKE_OSX_DEPLOYMENT_TARGET}` with `11.0`, The compilation can be successful. I am not very familiar with cmake. Do you have time to repair it? I noticed that you don't have an apple device to test. I can compile and test for you. @PragmaTwice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240216812
> Hi. I am using MacBook M1. According to [341a989#r80998035](https://github.com/apache/incubator-kvrocks/commit/341a989d75783d8dad76bbd5a4473dd345472337#r80998035), If I replace `${CMAKE_OSX_DEPLOYMENT_TARGET}` with `11.0`, The compilation can be successful. I am not very familiar with cmake. Do you have time to repair it? I noticed that you don't have an apple device to test. I can compile and test for you. @PragmaTwice
Hi @tanruixiang, actually you can directly pass the option to cmake, e.g. `cmake -DCMAKE_OSX_DEPLOYMENT_TARGET=10.3 ..`, `MACOSX_DEPLOYMENT_TARGET=10.3 cmake ..` or `./x.py build -DCMAKE_OSX_DEPLOYMENT_TARGET=10.3` rather than modifying cmake files.
If you want to try to fix this problem, you can add an `if ... else ...` to CMakeLists, i.e. when it is currently in macos and `CMAKE_OSX_DEPLOYMENT_TARGET` is not configured, an error should be reported and the user will be reminded to configure it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1242627983
Thanks for your contribution and fixing this issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240252246
> > Hi. I am using MacBook M1. According to [341a989#r80998035](https://github.com/apache/incubator-kvrocks/commit/341a989d75783d8dad76bbd5a4473dd345472337#r80998035), If I replace `${CMAKE_OSX_DEPLOYMENT_TARGET}` with `11.0`, The compilation can be successful. I am not very familiar with cmake. Do you have time to repair it? I noticed that you don't have an apple device to test. I can compile and test for you. @PragmaTwice
>
> Hi @tanruixiang, actually you can directly pass the option to cmake, e.g. `cmake -DCMAKE_OSX_DEPLOYMENT_TARGET=10.3 ..`, `MACOSX_DEPLOYMENT_TARGET=10.3 cmake ..` or `./x.py build -DCMAKE_OSX_DEPLOYMENT_TARGET=10.3` rather than modifying cmake files.
>
> If you want to try to fix this problem, you can add an `if ... else ...` to CMakeLists, i.e. when it is currently in macos and `CMAKE_OSX_DEPLOYMENT_TARGET` is not configured, an error should be reported and the user will be reminded to configure it.
The current error report is like this `Makefile:320: *** missing: export MACOSX_DEPLOYMENT_TARGET=XX.YY. Stop.`
As a new user, I will be a little confused about this error report. Can we update readme and note that MacOS needs to use the command you gave? Or if `MACOSX_DEPLOYMENT_TARGET` does not exist, give a default value(like 11.0 before).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice closed issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
PragmaTwice closed issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
URL: https://github.com/apache/incubator-kvrocks/issues/776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240279768
My current plan was narrated above:
> If you want to try to fix this problem, you can add an if ... else ... to CMakeLists, i.e. when it is currently in macos and CMAKE_OSX_DEPLOYMENT_TARGET is not configured, an error should be reported and the user will be reminded to configure it.
If you want to specify a default value, maybe you need to investigate how to specify a valid default value for most macos version (10.x, 11, ...) that mac users is currently using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org