[jira] [Work logged] (HIVE-25684) Many (~16K) skipped tests in TestGenericUDFInitializeOnCompareUDF

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25684?focusedWorklogId=679092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679092 ]

ASF GitHub Bot logged work on HIVE-25684:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Nov/21 14:59
            Start Date: 09/Nov/21 14:59
    Worklog Time Spent: 10m 
      Work Description: zabetak opened a new pull request #2775:
URL: https://github.com/apache/hive/pull/2775


   ### What changes were proposed in this pull request?
   Remove parameterized combinations leading to skipped tests and pass exactly the arguments we need in each test method.
   
   ### Why are the changes needed?
   Avoid polluting the test results with many skipped tests.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   `mvn test -Dtest=TestGenericUDFInitializeOnCompareUDF`  skipped tests do not appear anymore


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 679092)
    Remaining Estimate: 0h
            Time Spent: 10m

> Many (~16K) skipped tests in TestGenericUDFInitializeOnCompareUDF
> -----------------------------------------------------------------
>
>                 Key: HIVE-25684
>                 URL: https://issues.apache.org/jira/browse/HIVE-25684
>             Project: Hive
>          Issue Type: Task
>          Components: Testing Infrastructure
>    Affects Versions: 4.0.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>         Attachments: skipped_tests.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> TestGenericUDFInitializeOnCompareUDF is a parameterized test leading to 24K possible test combinations. From those only 7K are actually run and the rest (~16K) are skipped. 
> {noformat}
> mvn test -Dtest=TestGenericUDFInitializeOnCompareUDF
> ...
> [WARNING] Tests run: 24300, Failures: 0, Errors: 0, Skipped: 16452, Time elapsed: 7.098 s - in org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFInitializeOnCompareUDF
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 7848, Failures: 0, Errors: 0, Skipped: 0
> {noformat}
> This generates a lot of noise in Jenkins CI, where many tests appear as skipped, and it may make people believe it is a problem (side effect of their changes).  Moreover, we know in advance which tests are skipped and why so instead of generating invalid parameter combinations we could simply remove those combinations altogether.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)