You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/04/08 04:29:59 UTC
Review Request 32954: Added a 'slave_shutdowns_completed' metric.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32954/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
This allows us to determine the number of pending slave shutdowns,
as the scheduled shutdowns must either be canceled or completed.
Diffs
-----
src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
src/master/metrics.hpp 52a83289cfe7e6b6fd8d5bff0774ebe5ce51d0ed
src/master/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b
Diff: https://reviews.apache.org/r/32954/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 32954: Added a 'slave_shutdowns_completed' metric.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32954/#review79295
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32954]
All tests passed.
- Mesos ReviewBot
On April 8, 2015, 2:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32954/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 2:29 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to determine the number of pending slave shutdowns,
> as the scheduled shutdowns must either be canceled or completed.
>
>
> Diffs
> -----
>
> src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
> src/master/metrics.hpp 52a83289cfe7e6b6fd8d5bff0774ebe5ce51d0ed
> src/master/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b
>
> Diff: https://reviews.apache.org/r/32954/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 32954: Added a 'slave_shutdowns_completed' metric.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32954/#review80139
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 8, 2015, 2:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32954/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 2:29 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to determine the number of pending slave shutdowns,
> as the scheduled shutdowns must either be canceled or completed.
>
>
> Diffs
> -----
>
> src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
> src/master/metrics.hpp 52a83289cfe7e6b6fd8d5bff0774ebe5ce51d0ed
> src/master/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b
>
> Diff: https://reviews.apache.org/r/32954/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>