You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2026/05/14 21:23:14 UTC
[PR] Refactor ATR client and simple improvements in Mojos [tooling-atr-maven-plugin]
slawekjaranowski opened a new pull request, #5:
URL: https://github.com/apache/tooling-atr-maven-plugin/pull/5
What changed:
- Move `AtrClient` to `org.apache.tooling.atr.client`.
- Introduce `AtrClientFactory` service for simplified client creation in `AbstractAtrMojo`.
- Make `AtrClient` Maven Api agnostic.
- Use constructor injections in Mojos for services.
Why:
- We will easily provide a mock for `AtrClientFactory` for testing purpose.
- We can move `AtrClient` to separate library if needed in more projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [PR] Refactor ATR client and simple improvements in Mojos [tooling-atr-maven-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #5:
URL: https://github.com/apache/tooling-atr-maven-plugin/pull/5#issuecomment-4472581344
@hboutemy any comments, if no I assume that it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [PR] Refactor ATR client and simple improvements in Mojos [tooling-atr-maven-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #5:
URL: https://github.com/apache/tooling-atr-maven-plugin/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org