You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/09 08:56:10 UTC
[GitHub] [superset] aniaan opened a new pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
aniaan opened a new pull request #17048:
URL: https://github.com/apache/superset/pull/17048
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The elasticsearch `CAST` function does not take effect for the `time zone` setting. In ES7.8 and above, we can use the `DATETIME_PARSE` function to solve this problem.
In the current master code, the `extra` dict in the database contains the `version` key. We can use version to solve this problem. According to the instructions, version is set for `presto` at the beginning, and ES should also reuse this field.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Install the latest elasticsearch-dbapi version, 0.2.6, which supports setting the time_zone parameter `pip install elasticsearch-dbapi==0.2.6`
2. Follow the steps in #16726 to create an ES data source, create a data source, set the time_zone parameter and version
<img width="530" alt="截屏2021-10-09 下午4 47 33" src="https://user-images.githubusercontent.com/40813941/136651378-32fe75c1-a703-416d-ae7c-cdf3db122bb4.png">
3. Follow the operation steps in #16726 to analyze, and you can see that the DATETIME_PARSE function and time_zone parameter play a correct role
<img width="1903" alt="截屏2021-10-09 下午4 50 14" src="https://user-images.githubusercontent.com/40813941/136651464-9e86c7b8-c2ae-4026-b09c-62f36aacfb02.png">
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #16726
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa600a6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **increase** coverage by `0.00%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
=======================================
Coverage 76.86% 76.87%
=======================================
Files 1042 1042
Lines 56254 56271 +17
Branches 7785 7785
=======================================
+ Hits 43242 43259 +17
Misses 12754 12754
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.54% <94.11%> (+0.01%)` | :arrow_up: |
| mysql | `81.96% <94.11%> (+0.01%)` | :arrow_up: |
| postgres | `81.97% <94.11%> (+0.01%)` | :arrow_up: |
| python | `82.32% <94.11%> (+0.01%)` | :arrow_up: |
| sqlite | `81.65% <94.11%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.54% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `95.83% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.07% <88.88%> (+0.05%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...aa600a6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r747293931
##########
File path: superset/db_engine_specs/base.py
##########
@@ -686,13 +685,14 @@ def df_to_sql(
@classmethod
def convert_dttm( # pylint: disable=unused-argument
- cls, target_type: str, dttm: datetime,
+ cls, target_type: str, dttm: datetime, **kwargs: Any,
Review comment:
Is there a reason this is `**kwargs: Any` and not `db_extra: Optional[Dict[str, Any]]` like has been done in `get_column_spec`? Unpacking into kwargs will make more difficult to add new parameters to this method going forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r747335499
##########
File path: superset/db_engine_specs/base.py
##########
@@ -686,13 +685,14 @@ def df_to_sql(
@classmethod
def convert_dttm( # pylint: disable=unused-argument
- cls, target_type: str, dttm: datetime,
+ cls, target_type: str, dttm: datetime, **kwargs: Any,
Review comment:
Yes, we can, then we will not add it for now, and we will consider it later if we have this situation.
I'll correct the PR later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d96aec6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **decrease** coverage by `0.13%`.
> The diff coverage is `94.73%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.86% 76.73% -0.14%
==========================================
Files 1042 1042
Lines 56254 56262 +8
Branches 7785 7785
==========================================
- Hits 43242 43173 -69
- Misses 12754 12831 +77
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.96% <94.73%> (+<0.01%)` | :arrow_up: |
| postgres | `81.97% <94.73%> (+<0.01%)` | :arrow_up: |
| python | `82.05% <94.73%> (-0.26%)` | :arrow_down: |
| sqlite | `81.64% <94.73%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.15% <ø> (-0.44%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.85% <88.88%> (-0.17%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `90.00% <100.00%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...d96aec6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6328816) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **decrease** coverage by `0.07%`.
> The diff coverage is `94.82%`.
> :exclamation: Current head 6328816 differs from pull request most recent head d96aec6. Consider uploading reports for the commit d96aec6 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.86% 76.79% -0.08%
==========================================
Files 1042 1039 -3
Lines 56254 56041 -213
Branches 7785 7735 -50
==========================================
- Hits 43242 43039 -203
+ Misses 12754 12744 -10
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.92% <94.82%> (-0.03%)` | :arrow_down: |
| postgres | `81.93% <94.82%> (-0.03%)` | :arrow_down: |
| python | `81.98% <94.82%> (-0.34%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.57% <ø> (-1.02%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.42% <90.00%> (-0.60%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `88.23% <100.00%> (-3.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `90.00% <100.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...d96aec6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r749921728
##########
File path: superset/db_engine_specs/base.py
##########
@@ -686,13 +685,14 @@ def df_to_sql(
@classmethod
def convert_dttm( # pylint: disable=unused-argument
- cls, target_type: str, dttm: datetime,
+ cls, target_type: str, dttm: datetime, **kwargs: Any,
Review comment:
@villebro I have updated it, you can review it when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r750361686
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,9 +60,24 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, db_extra: Optional[Dict[str, Any]] = None
+ ) -> Optional[str]:
+
+ db_extra = db_extra if db_extra else {}
if target_type.upper() == utils.TemporalType.DATETIME:
+ es_version = db_extra.get("version")
+ # The elasticsearch CAST function does not take effect for the time zone
+ # setting. In elasticsearch7.8 and above, we can use the DATETIME_PARSE
+ # function to solve this problem.
+ if es_version and StrictVersion(es_version) >= StrictVersion("7.8"):
+ datetime_formatted = dttm.isoformat(sep=" ", timespec="seconds")
+ return (
+ f"""DATETIME_PARSE('{datetime_formatted}', 'yyyy-MM-dd HH:mm:ss')"""
+ )
Review comment:
I have updated it, you can review it when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (778f401) into [master](https://codecov.io/gh/apache/superset/commit/0257cf774d034f17d60c84cb6d1bd6762d7720fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0257cf7) will **decrease** coverage by `0.06%`.
> The diff coverage is `94.64%`.
> :exclamation: Current head 778f401 differs from pull request most recent head 5e43a5c. Consider uploading reports for the commit 5e43a5c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.81% 76.75% -0.07%
==========================================
Files 1038 1031 -7
Lines 56025 55188 -837
Branches 7735 7506 -229
==========================================
- Hits 43035 42357 -678
+ Misses 12732 12579 -153
+ Partials 258 252 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `81.93% <92.85%> (+0.01%)` | :arrow_up: |
| presto | `81.80% <94.64%> (?)` | |
| python | `82.15% <94.64%> (+0.14%)` | :arrow_up: |
| sqlite | `81.60% <92.85%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.52% <ø> (+0.32%)` | :arrow_up: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.95% <81.81%> (+0.59%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `85.97% <100.00%> (+1.12%)` | :arrow_up: |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `90.00% <100.00%> (ø)` | |
| ... and [237 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0257cf7...5e43a5c](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r750361686
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,9 +60,24 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, db_extra: Optional[Dict[str, Any]] = None
+ ) -> Optional[str]:
+
+ db_extra = db_extra if db_extra else {}
if target_type.upper() == utils.TemporalType.DATETIME:
+ es_version = db_extra.get("version")
+ # The elasticsearch CAST function does not take effect for the time zone
+ # setting. In elasticsearch7.8 and above, we can use the DATETIME_PARSE
+ # function to solve this problem.
+ if es_version and StrictVersion(es_version) >= StrictVersion("7.8"):
+ datetime_formatted = dttm.isoformat(sep=" ", timespec="seconds")
+ return (
+ f"""DATETIME_PARSE('{datetime_formatted}', 'yyyy-MM-dd HH:mm:ss')"""
+ )
Review comment:
@villebro I have updated it, you can review it when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6328816) into [master](https://codecov.io/gh/apache/superset/commit/0257cf774d034f17d60c84cb6d1bd6762d7720fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0257cf7) will **decrease** coverage by `0.01%`.
> The diff coverage is `95.50%`.
> :exclamation: Current head 6328816 differs from pull request most recent head 5e43a5c. Consider uploading reports for the commit 5e43a5c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.81% 76.79% -0.02%
==========================================
Files 1038 1039 +1
Lines 56025 56041 +16
Branches 7735 7735
==========================================
+ Hits 43035 43039 +4
- Misses 12732 12744 +12
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.92% <96.55%> (+<0.01%)` | :arrow_up: |
| postgres | `81.93% <96.55%> (+<0.01%)` | :arrow_up: |
| python | `81.98% <96.55%> (-0.04%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `56.52% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.57% <ø> (-0.63%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.98% <ø> (-0.14%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.42% <90.00%> (+0.06%)` | :arrow_up: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `68.30% <100.00%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `85.86% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `67.47% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0257cf7...5e43a5c](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r750150715
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,9 +60,24 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, db_extra: Optional[Dict[str, Any]] = None
+ ) -> Optional[str]:
+
+ db_extra = db_extra if db_extra else {}
Review comment:
nit: `db_extra = db_extra or {}` should do the job, too
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,9 +60,24 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, db_extra: Optional[Dict[str, Any]] = None
+ ) -> Optional[str]:
+
+ db_extra = db_extra if db_extra else {}
if target_type.upper() == utils.TemporalType.DATETIME:
+ es_version = db_extra.get("version")
+ # The elasticsearch CAST function does not take effect for the time zone
+ # setting. In elasticsearch7.8 and above, we can use the DATETIME_PARSE
+ # function to solve this problem.
+ if es_version and StrictVersion(es_version) >= StrictVersion("7.8"):
+ datetime_formatted = dttm.isoformat(sep=" ", timespec="seconds")
+ return (
+ f"""DATETIME_PARSE('{datetime_formatted}', 'yyyy-MM-dd HH:mm:ss')"""
+ )
Review comment:
I wonder if we should have a fallback/more clear error message if the version isn't parseable by `StrictVersion` (Since this is to be populated by the user, we can expect to bump into unparseable values here):
```python
>>> from distutils.version import StrictVersion
>>> StrictVersion("7.8.0.0")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/ville/.pyenv/versions/3.8-dev/lib/python3.8/distutils/version.py", line 40, in __init__
self.parse(vstring)
File "/Users/ville/.pyenv/versions/3.8-dev/lib/python3.8/distutils/version.py", line 137, in parse
raise ValueError("invalid version number '%s'" % vstring)
ValueError: invalid version number '7.8.0.0'
```
Same for non-string values (I expect someone may try to enter it as a number, not string):
```python
>>> StrictVersion(7.8)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/ville/.pyenv/versions/3.8-dev/lib/python3.8/distutils/version.py", line 40, in __init__
self.parse(vstring)
File "/Users/ville/.pyenv/versions/3.8-dev/lib/python3.8/distutils/version.py", line 135, in parse
match = self.version_re.match(vstring)
TypeError: expected string or bytes-like object
```
Just in case, perhaps we could do something as simple as
```python
supports_dttm_parse = False
try:
if es_version:
supports_dttm_parse = StrictVersion(es_version) >= StrictVersion("7.8")
except ValueError:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r726175374
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,10 +60,20 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
- if target_type.upper() == utils.TemporalType.DATETIME:
- return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
- return None
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, **kwargs: Any
+ ) -> Optional[str]:
+
+ if target_type.upper() != utils.TemporalType.DATETIME:
+ return None
+
+ es_version = kwargs.get("version")
+
+ if es_version and StrictVersion(es_version) >= StrictVersion("7.8"):
+ datetime_formatted = dttm.isoformat(sep=" ", timespec="seconds")
+ return f"""DATETIME_PARSE('{datetime_formatted}', 'yyyy-MM-dd HH:mm:ss')"""
Review comment:
It was first written according to the way of not short-circuiting, so there will be nested if. If the f-string is written in one line, then the length of this line will be too long, so the expression is extracted. This way of writing refers to drill .py#convert_dttm method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r747324802
##########
File path: superset/db_engine_specs/base.py
##########
@@ -686,13 +685,14 @@ def df_to_sql(
@classmethod
def convert_dttm( # pylint: disable=unused-argument
- cls, target_type: str, dttm: datetime,
+ cls, target_type: str, dttm: datetime, **kwargs: Any,
Review comment:
@aniaan I'd prefer not to add `**kwargs` unless it's currently needed (it's easy enough to add later when the need comes up). And thinking more closely, I'd personally prefer to keep all arguments named so that all parameters in the method are explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (356dbe3) into [master](https://codecov.io/gh/apache/superset/commit/7c1c89c94b900ffe3de75c9cb314a75a3b559801?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1c89c) will **decrease** coverage by `0.23%`.
> The diff coverage is `91.52%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.91% 76.67% -0.24%
==========================================
Files 1031 1031
Lines 55163 55170 +7
Branches 7501 7501
==========================================
- Hits 42428 42303 -125
- Misses 12483 12615 +132
Partials 252 252
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `81.93% <91.52%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `81.97% <91.52%> (-0.46%)` | :arrow_down: |
| sqlite | `81.60% <91.52%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.13% <ø> (-0.44%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.54% <72.72%> (-1.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `91.30% <90.90%> (+1.06%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `85.97% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <100.00%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c1c89c...356dbe3](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (356dbe3) into [master](https://codecov.io/gh/apache/superset/commit/7c1c89c94b900ffe3de75c9cb314a75a3b559801?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1c89c) will **decrease** coverage by `0.07%`.
> The diff coverage is `91.52%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.91% 76.83% -0.08%
==========================================
Files 1031 1031
Lines 55163 55170 +7
Branches 7501 7501
==========================================
- Hits 42428 42392 -36
- Misses 12483 12526 +43
Partials 252 252
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.47% <91.52%> (+<0.01%)` | :arrow_up: |
| mysql | `81.92% <91.52%> (+<0.01%)` | :arrow_up: |
| postgres | `81.93% <91.52%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `82.28% <91.52%> (-0.15%)` | :arrow_down: |
| sqlite | `81.60% <91.52%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.52% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.78% <72.72%> (-1.47%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `91.30% <90.90%> (+1.06%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `85.97% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <100.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c1c89c...356dbe3](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r726162790
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,10 +60,20 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
- if target_type.upper() == utils.TemporalType.DATETIME:
- return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
- return None
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, **kwargs: Any
+ ) -> Optional[str]:
+
+ if target_type.upper() != utils.TemporalType.DATETIME:
Review comment:
I think the previous logic of not short circuiting is clearer, i.e., if `DATETIME` then `…`.
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,10 +60,20 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
- if target_type.upper() == utils.TemporalType.DATETIME:
- return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
- return None
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, **kwargs: Any
+ ) -> Optional[str]:
+
+ if target_type.upper() != utils.TemporalType.DATETIME:
+ return None
+
+ es_version = kwargs.get("version")
+
+ if es_version and StrictVersion(es_version) >= StrictVersion("7.8"):
+ datetime_formatted = dttm.isoformat(sep=" ", timespec="seconds")
+ return f"""DATETIME_PARSE('{datetime_formatted}', 'yyyy-MM-dd HH:mm:ss')"""
Review comment:
Why not use the f-string as previously?
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,10 +60,20 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
- if target_type.upper() == utils.TemporalType.DATETIME:
- return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
- return None
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, **kwargs: Any
+ ) -> Optional[str]:
+
+ if target_type.upper() != utils.TemporalType.DATETIME:
+ return None
+
+ es_version = kwargs.get("version")
Review comment:
Should this be documented somewhere? It might not be apparent to the user why the behavior differs by version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (356dbe3) into [master](https://codecov.io/gh/apache/superset/commit/7c1c89c94b900ffe3de75c9cb314a75a3b559801?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1c89c) will **decrease** coverage by `0.21%`.
> The diff coverage is `91.52%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.91% 76.69% -0.22%
==========================================
Files 1031 1031
Lines 55163 55170 +7
Branches 7501 7501
==========================================
- Hits 42428 42315 -113
- Misses 12483 12603 +120
Partials 252 252
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.92% <91.52%> (+<0.01%)` | :arrow_up: |
| postgres | `81.93% <91.52%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `82.02% <91.52%> (-0.42%)` | :arrow_down: |
| sqlite | `81.60% <91.52%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.13% <ø> (-0.44%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.54% <72.72%> (-1.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `91.30% <90.90%> (+1.06%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `85.97% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <100.00%> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c1c89c...356dbe3](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa600a6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **decrease** coverage by `0.12%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.86% 76.73% -0.13%
==========================================
Files 1042 1042
Lines 56254 56271 +17
Branches 7785 7785
==========================================
- Hits 43242 43182 -60
- Misses 12754 12831 +77
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.96% <94.11%> (+0.01%)` | :arrow_up: |
| postgres | `81.97% <94.11%> (+0.01%)` | :arrow_up: |
| python | `82.06% <94.11%> (-0.26%)` | :arrow_down: |
| sqlite | `81.65% <94.11%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.15% <ø> (-0.44%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `95.83% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.85% <88.88%> (-0.17%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...aa600a6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (778f401) into [master](https://codecov.io/gh/apache/superset/commit/7c1c89c94b900ffe3de75c9cb314a75a3b559801?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1c89c) will **decrease** coverage by `0.16%`.
> The diff coverage is `80.21%`.
> :exclamation: Current head 778f401 differs from pull request most recent head 82ed2cd. Consider uploading reports for the commit 82ed2cd to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.91% 76.75% -0.17%
==========================================
Files 1031 1031
Lines 55163 55188 +25
Branches 7501 7506 +5
==========================================
- Hits 42428 42357 -71
- Misses 12483 12579 +96
Partials 252 252
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `81.93% <92.85%> (+<0.01%)` | :arrow_up: |
| presto | `81.80% <94.64%> (+<0.01%)` | :arrow_up: |
| python | `82.15% <94.64%> (-0.28%)` | :arrow_down: |
| sqlite | `81.60% <92.85%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/profile/components/CreatedContent.tsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9DcmVhdGVkQ29udGVudC50c3g=) | `87.50% <ø> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.52% <ø> (-0.05%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `54.54% <33.33%> (-8.32%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `74.52% <63.63%> (-0.72%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.95% <81.81%> (-0.30%)` | :arrow_down: |
| [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | `60.60% <87.50%> (-28.68%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `95.12% <100.00%> (+3.55%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c1c89c...82ed2cd](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r726179407
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,10 +60,20 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
- if target_type.upper() == utils.TemporalType.DATETIME:
- return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
- return None
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, **kwargs: Any
+ ) -> Optional[str]:
+
+ if target_type.upper() != utils.TemporalType.DATETIME:
+ return None
+
+ es_version = kwargs.get("version")
Review comment:
Yes, a note should be added here to explain the differences brought by the versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa600a6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **increase** coverage by `0.08%`.
> The diff coverage is `95.58%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
+ Coverage 76.86% 76.95% +0.08%
==========================================
Files 1042 1042
Lines 56254 56271 +17
Branches 7785 7785
==========================================
+ Hits 43242 43301 +59
+ Misses 12754 12712 -42
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.54% <94.11%> (+0.01%)` | :arrow_up: |
| mysql | `81.96% <94.11%> (+0.01%)` | :arrow_up: |
| postgres | `81.97% <94.11%> (+0.01%)` | :arrow_up: |
| presto | `81.83% <95.58%> (?)` | |
| python | `82.47% <95.58%> (+0.15%)` | :arrow_up: |
| sqlite | `81.65% <94.11%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.54% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `95.83% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.42% <100.00%> (+1.40%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...aa600a6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d96aec6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **increase** coverage by `0.00%`.
> The diff coverage is `94.73%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
=======================================
Coverage 76.86% 76.87%
=======================================
Files 1042 1042
Lines 56254 56262 +8
Branches 7785 7785
=======================================
+ Hits 43242 43250 +8
Misses 12754 12754
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.53% <94.73%> (+<0.01%)` | :arrow_up: |
| mysql | `81.96% <94.73%> (+<0.01%)` | :arrow_up: |
| postgres | `81.97% <94.73%> (+<0.01%)` | :arrow_up: |
| python | `82.32% <94.73%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.64% <94.73%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.54% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.07% <88.88%> (+0.05%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `90.00% <100.00%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...d96aec6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #17048:
URL: https://github.com/apache/superset/pull/17048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (356dbe3) into [master](https://codecov.io/gh/apache/superset/commit/7c1c89c94b900ffe3de75c9cb314a75a3b559801?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1c89c) will **decrease** coverage by `0.07%`.
> The diff coverage is `91.52%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
- Coverage 76.91% 76.83% -0.08%
==========================================
Files 1031 1031
Lines 55163 55170 +7
Branches 7501 7501
==========================================
- Hits 42428 42392 -36
- Misses 12483 12526 +43
Partials 252 252
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.47% <91.52%> (+<0.01%)` | :arrow_up: |
| mysql | `81.92% <91.52%> (+<0.01%)` | :arrow_up: |
| postgres | `81.93% <91.52%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `82.28% <91.52%> (-0.15%)` | :arrow_down: |
| sqlite | `81.60% <91.52%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.52% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.78% <72.72%> (-1.47%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `91.30% <90.90%> (+1.06%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `85.97% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <100.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c1c89c...356dbe3](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r726254177
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -59,10 +60,20 @@ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]:
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
- if target_type.upper() == utils.TemporalType.DATETIME:
- return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
- return None
+ def convert_dttm(
+ cls, target_type: str, dttm: datetime, **kwargs: Any
+ ) -> Optional[str]:
+
+ if target_type.upper() != utils.TemporalType.DATETIME:
+ return None
+
+ es_version = kwargs.get("version")
Review comment:
> Should this be documented somewhere? It might not be apparent to the user why the behavior differs by version.
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aniaan commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
aniaan commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r747319895
##########
File path: superset/db_engine_specs/base.py
##########
@@ -686,13 +685,14 @@ def df_to_sql(
@classmethod
def convert_dttm( # pylint: disable=unused-argument
- cls, target_type: str, dttm: datetime,
+ cls, target_type: str, dttm: datetime, **kwargs: Any,
Review comment:
Indeed, the writing here is not strict enough, for `db_extra`, it is better to show the declaration type, I think, the method signature can be like this, `def convert_dttm(cls, target_type: str, dttm: datetime, db_extra: Optional[Dict[str, Any]], **kwargs: Any)` also continue to retain `kwargs`, so that later if a data source needs non-db_extra information, this way is also compatible, what do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d96aec6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **increase** coverage by `0.08%`.
> The diff coverage is `96.49%`.
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
+ Coverage 76.86% 76.95% +0.08%
==========================================
Files 1042 1042
Lines 56254 56262 +8
Branches 7785 7785
==========================================
+ Hits 43242 43294 +52
+ Misses 12754 12710 -44
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.53% <94.73%> (+<0.01%)` | :arrow_up: |
| mysql | `81.96% <94.73%> (+<0.01%)` | :arrow_up: |
| postgres | `81.97% <94.73%> (+<0.01%)` | :arrow_up: |
| presto | `81.84% <96.49%> (?)` | |
| python | `82.47% <96.49%> (+0.15%)` | :arrow_up: |
| sqlite | `81.64% <94.73%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.54% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.42% <100.00%> (+1.40%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `90.00% <100.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...d96aec6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17048:
URL: https://github.com/apache/superset/pull/17048#issuecomment-939262848
# [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17048](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d96aec6) into [master](https://codecov.io/gh/apache/superset/commit/3ee9e11ce1bfc2f74ef8bfcd2ee0cc6a3f2249ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee9e11) will **increase** coverage by `0.08%`.
> The diff coverage is `96.49%`.
> :exclamation: Current head d96aec6 differs from pull request most recent head aa600a6. Consider uploading reports for the commit aa600a6 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17048 +/- ##
==========================================
+ Coverage 76.86% 76.95% +0.08%
==========================================
Files 1042 1042
Lines 56254 56262 +8
Branches 7785 7785
==========================================
+ Hits 43242 43294 +52
+ Misses 12754 12710 -44
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.53% <94.73%> (+<0.01%)` | :arrow_up: |
| mysql | `81.96% <94.73%> (+<0.01%)` | :arrow_up: |
| postgres | `81.97% <94.73%> (+<0.01%)` | :arrow_up: |
| presto | `81.84% <96.49%> (?)` | |
| python | `82.47% <96.49%> (+0.15%)` | :arrow_up: |
| sqlite | `81.64% <94.73%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.54% <ø> (-0.05%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/databricks.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `90.00% <66.66%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.42% <100.00%> (+1.40%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `92.15% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `89.28% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.84% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `66.03% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `90.00% <100.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/superset/pull/17048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ee9e11...aa600a6](https://codecov.io/gh/apache/superset/pull/17048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org