You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by zhangh43 <gi...@git.apache.org> on 2016/09/26 09:46:13 UTC
[GitHub] incubator-hawq pull request #939: HAWQ-991. Fix bug of yaml configuration fi...
GitHub user zhangh43 opened a pull request:
https://github.com/apache/incubator-hawq/pull/939
HAWQ-991. Fix bug of yaml configuration file contains only files unde\u2026
\u2026r table directory in --force mode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangh43/incubator-hawq d07
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/939.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #939
----
commit cde0a79828df8fdea3874de1fdd6d5fcc286d044
Author: hzhang2 <zh...@163.com>
Date: 2016-09-26T09:45:18Z
HAWQ-991. Fix bug of yaml configuration file contains only files under table directory in --force mode.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #939: HAWQ-991. Fix bug of yaml configuration fi...
Posted by kdunn-pivotal <gi...@git.apache.org>.
Github user kdunn-pivotal commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/939#discussion_r80729846
--- Diff: tools/bin/hawqregister ---
@@ -729,6 +728,23 @@ class HawqRegister(object):
for k, eof in enumerate(eofs[1:]):
query += ',(%d, %d, %d, %d, %d)' % (self.firstsegno + k + 1, eof, -1, -1, -1)
--- End diff --
Yes, upgrade to 3.x is a big deal - I'm definitely *not* proposing that. Rather, we should minimize the technical debt by making net-new code (like this tool) better aligned with 3.x conventions, to avoid revisiting it later on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #939: HAWQ-991. Fix bug of yaml configuration fi...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/939#discussion_r80613855
--- Diff: tools/bin/hawqregister ---
@@ -729,6 +728,23 @@ class HawqRegister(object):
for k, eof in enumerate(eofs[1:]):
query += ',(%d, %d, %d, %d, %d)' % (self.firstsegno + k + 1, eof, -1, -1, -1)
--- End diff --
Thanks @kdunn-pivotal for the good advice. But I think upgrade from Python2.x to Python3.x is a big deal and since we are not familiar with Python3.x, current code is ok. For the syntax you mentioned here, you are right. TIL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #939: HAWQ-991. Fix bug of yaml configuration fi...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/939#discussion_r80612789
--- Diff: tools/bin/hawqregister ---
@@ -603,9 +605,6 @@ class HawqRegister(object):
self._check_files_and_table_in_same_hdfs_cluster(self.filepath, self.tabledir)
- if not self.yml:
- check_no_regex_filepath([self.filepath])
- self.files, self.sizes = self._get_files_in_hdfs(self.filepath)
print 'New file(s) to be registered: ', self.files
--- End diff --
Here should print `self.newfiles` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #939: HAWQ-991. Fix bug of yaml configuration fi...
Posted by kdunn-pivotal <gi...@git.apache.org>.
Github user kdunn-pivotal commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/939#discussion_r80594744
--- Diff: tools/bin/hawqregister ---
@@ -729,6 +728,23 @@ class HawqRegister(object):
for k, eof in enumerate(eofs[1:]):
query += ',(%d, %d, %d, %d, %d)' % (self.firstsegno + k + 1, eof, -1, -1, -1)
--- End diff --
This is minor, but I believe the `%` syntax is being [deprecated](https://www.python.org/dev/peps/pep-3101/) in Python 3.x. Maybe consider replacing it with the new `.format` syntax.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #939: HAWQ-991. Fix bug of yaml configuration fi...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---