You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/08 12:30:29 UTC
[GitHub] [ignite] isapego opened a new pull request, #10426: IGNITE-18346 Fix timestamp part of Ignite version in .NET
isapego opened a new pull request, #10426:
URL: https://github.com/apache/ignite/pull/10426
- Fixed timestamp part of Ignite version in .NET;
- Added test (needs review).
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn merged pull request #10426: IGNITE-18346 .NET: Fix timestamp in IgniteProductVersion
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged PR #10426:
URL: https://github.com/apache/ignite/pull/10426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on pull request #10426: IGNITE-18346 Fix timestamp part of Ignite version in .NET
Posted by GitBox <gi...@apache.org>.
isapego commented on PR #10426:
URL: https://github.com/apache/ignite/pull/10426#issuecomment-1346020837
@ptupitsyn looks great, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on pull request #10426: IGNITE-18346 Fix timestamp part of Ignite version in .NET
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on PR #10426:
URL: https://github.com/apache/ignite/pull/10426#issuecomment-1345987095
@isapego thanks for the fix. I've also moved the revision timestamp conversion logic from `BinaryUtils` to `IgniteProductVersion`, since it is specific to this part of code, and uses "seconds from epoch" unlike anything else. Renamed it and added comments as well to make it more clear. Please review my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org