You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/04 02:06:11 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #720: SDIO:
Make interface field names conform to standard.
patacongo opened a new pull request #720: SDIO: Make interface field names conform to standard.
URL: https://github.com/apache/incubator-nuttx/pull/720
The SDIO interface structure includes fields with names like recvR1 and others. These cause "Mixed case identifier" errors from nxstyle in all places they are uses.
This change performs a mass substition of recvR with recv_r to correct this coding standard violation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #720: SDIO:
Make interface field names conform to standard.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #720: SDIO: Make interface field names conform to standard.
URL: https://github.com/apache/incubator-nuttx/pull/720#issuecomment-608985235
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #720: SDIO: Make
interface field names conform to standard.
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #720: SDIO: Make interface field names conform to standard.
URL: https://github.com/apache/incubator-nuttx/pull/720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #720: SDIO:
Make interface field names conform to standard.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #720: SDIO: Make interface field names conform to standard.
URL: https://github.com/apache/incubator-nuttx/pull/720#issuecomment-608955707
Please note. This is a work in progress. The initial commit just addresses the name change. A subsequent commit will handle the numerous, expected nxstyle failures. It is certainly ready for review sans nxstyle fixes for anyone who is interested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #720: SDIO: Make
interface field names conform to standard.
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #720: SDIO: Make interface field names conform to standard.
URL: https://github.com/apache/incubator-nuttx/pull/720#issuecomment-608955707
Please note. This is a work in progress. The initial commit just addresses the name change. A subsequent commit will hand the numerous expected nxstyle failures. It is certainly ready for review sans nxstyle fixes for anyone who is interested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services