You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Jarkko Viinamäki (JIRA)" <de...@velocity.apache.org> on 2009/01/11 13:03:59 UTC
[jira] Resolved: (VELOCITY-665) issues.Velocity614TestCase fails
because patch for VELOCITY-71 was removed
[ https://issues.apache.org/jira/browse/VELOCITY-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarkko Viinamäki resolved VELOCITY-665.
---------------------------------------
Resolution: Invalid
Oops for some reason I didn't get all the updates (maybe I had updated the wrong directory?). The test passes now and the implementation looks good. My mistake. Marking this as invalid.
> issues.Velocity614TestCase fails because patch for VELOCITY-71 was removed
> --------------------------------------------------------------------------
>
> Key: VELOCITY-665
> URL: https://issues.apache.org/jira/browse/VELOCITY-665
> Project: Velocity
> Issue Type: Bug
> Affects Versions: 1.6.2, 1.7
> Reporter: Jarkko Viinamäki
> Assignee: Byron Foster
>
> In VelocimacroProxy.checkArgs there is no longer check for the validity of macro arguments. As a result, Velocity614TestCase fails. I can't see why we could remove the macro argument check?
> Otherwise good job on refactoring the init/checkArgs logic. I was thinking about the same thing. Now there is no synchronized block overhead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org