You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 17:19:25 UTC

[commons-bcel] branch master updated: Remove useless returns.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new c26d888  Remove useless returns.
c26d888 is described below

commit c26d888c2571fc6202c6a7d22d17ca3ca6ee624c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Nov 21 12:19:21 2020 -0500

    Remove useless returns.
---
 src/main/java/org/apache/bcel/classfile/Signature.java                 | 1 -
 .../org/apache/bcel/verifier/structurals/InstConstraintVisitor.java    | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/src/main/java/org/apache/bcel/classfile/Signature.java b/src/main/java/org/apache/bcel/classfile/Signature.java
index 88cfdc5..ce3a09d 100644
--- a/src/main/java/org/apache/bcel/classfile/Signature.java
+++ b/src/main/java/org/apache/bcel/classfile/Signature.java
@@ -222,7 +222,6 @@ public final class Signature extends Attribute {
             matchGJIdent(in, buf);
         } else if (ch == ')') {
             in.unread();
-            return;
         } else if (ch != ';') {
             throw new IllegalArgumentException("Illegal signature: " + in.getData() + " read " + (char) ch);
         }
diff --git a/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java b/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java
index 35a71c9..ce816bd 100644
--- a/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java
+++ b/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java
@@ -992,9 +992,6 @@ public class InstConstraintVisitor extends EmptyVisitor{
                 constraintViolated(o, "If stack top's size is 2, then stack next-to-top's size must be 1. But it is '"+
                     stack().peek(1)+"' of size '"+stack().peek(1).getSize()+"'.");
             }
-            else{
-                return; // Form 2
-            }
         }
         else{ // stack top is of size 1
             if ( stack().peek(1).getSize() != 1 ) {