You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/09/21 02:46:24 UTC

[GitHub] [drill] cgivre opened a new pull request, #2657: DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader

cgivre opened a new pull request, #2657:
URL: https://github.com/apache/drill/pull/2657

   # [DRILL-8316](https://issues.apache.org/jira/browse/DRILL-8316): Convert Druid Storage Plugin to EVF & V2 JSON Reader
   
   ## Description
   Converts the Druid storage plugin to use the V2 JSON reader.
   
   ## Documentation
   No user facing changes.
   
   ## Testing
   Ran existing unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader (drill)

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2657:
URL: https://github.com/apache/drill/pull/2657#issuecomment-2227577005

   @jnturton 
   Could you do a review of this.  I realized that this has been languishing and we might as well merge it if it can be.   
   The one area which I'm a little hesitant about is the ScanBatchCreator.  Basically, since I didn't write this storage plugin and it was a bit more complicated than some of the ones I've written, I'd like another set of eyes on it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2657: DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2657:
URL: https://github.com/apache/drill/pull/2657#issuecomment-1427088906

   @Z0ltrix Would you mind reviewing this?   The unit tests pass, but I'm not 100% certain this is handling large data sets correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org