[GitHub] [incubator-tuweni] cleishm commented on a change in pull request #19: SSZ v0.5.0 Related Changes

[GitBox <gi...@apache.org>]

cleishm commented on a change in pull request #19: SSZ v0.5.0 Related Changes
URL: https://github.com/apache/incubator-tuweni/pull/19#discussion_r292530633
 
 

 ##########
 File path: ssz/src/main/java/org/apache/tuweni/ssz/SSZReader.java
 ##########
 @@ -51,6 +51,32 @@ default Bytes readBytes() {
    */
   Bytes readBytes(int limit);
 
+  /**
+   * Read a known size fixed-length bytes value from the SSZ source.
+   *
+   * Note: prefer to use {@link #readFixedBytes(int, int)} instead, especially when reading untrusted data.
+   *
+   * @param byteLength The number of fixed-length Bytes (no length mixin) to read.
 
 Review comment:
   'fixed-length Bytes` is a tautology.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org