You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2017/04/12 00:19:00 UTC
[GitHub] cordova-lib pull request #541: Exit with exitCode:1 if a plugin could not be...
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/541
Exit with exitCode:1 if a plugin could not be restored from config.xml
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
lib
### What does this PR do?
see description
### What testing has been done on this change?
manual testing
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-lib CB-12649
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #541
----
commit 540bcb97311ecb133ef3e71ad05636fbbe87f2d3
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2017-04-12T00:17:29Z
Exit with exitCode:1 if a plugin could not be restored from config.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #541: Exit with exitCode:1 if a plugin could not be restor...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/541
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=h1) Report
> Merging [#541](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/0d637f2d67a95ef709443eaa9d7481eb14f79b8d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 82.42% 82.42% +<.01%
==========================================
Files 68 68
Lines 5462 5463 +1
Branches 1072 1072
==========================================
+ Hits 4502 4503 +1
Misses 960 960
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz) | `95.81% <100%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=footer). Last update [0d637f2...540bcb9](https://codecov.io/gh/apache/cordova-lib/pull/541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #541: Exit with exitCode:1 if a plugin could not be...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org